notid/integreat
1
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Compare commits

merge into: notid:master
Branches Tags
notid:master notid:test-plan-docs notid:feat/complete-sales-summaries notid:migrate-ssr notid:feat/sales-parquet-migration notid:staging notid:sales-cleanup
...
pull from: notid:test-plan-docs
Branches Tags
notid:test-plan-docs notid:master notid:feat/complete-sales-summaries notid:migrate-ssr notid:feat/sales-parquet-migration notid:staging notid:sales-cleanup

2 Commits

Author SHA1 Message Date
Bryce
ececdc8f5f test(invoice): add integration tests for invoice behaviors 
- Fix schema ordering: move :journal-entry-line/running-balance to schema.edn
- Add invoice_behaviors_test.clj covering:
  - Permission gates (26.5, 26.6, 26.8)
  - Lock date blocking (27.1, 27.3)
  - New invoice validation (8.1, 8.5)
  - Edit invoice (11.1, 11.3)
  - Bulk edit (15.4)
  - Single/bulk void (16.3, 16.4, 17.1)
  - Unvoid restoring from history (18.1)
  - Undo autopay (19.1)
  - Invoice list filtering (2.6, 2.8, 2.10, 2.14)
  - Invoice list sorting (3.5, 3.7, 3.10)
  - Invoice list pagination (4.1, 4.3)
  - Legacy route redirects (28.1)
- Mock Solr in wrap-setup fixture to prevent Connection refused
- Fix setup-test-data to merge user-provided entities with defaults
- Fix InMemSolrClient.index_documents to handle entity IDs
- Fix ezcater_xls test to use dynamic entity IDs
- Update invoice.md behavior checklist with completed items
 2026-05-04 23:10:46 -07:00
Bryce
da7897c0d6 test(invoice): implement unit tests for invoice behaviors 
Add comprehensive unit tests for pure invoice business logic:
- assert-invoice-amounts-add-up (behaviors 9.4, 11.4)
- does-amount-exceed-outstanding? (behavior 13.4)
- assert-percentages-add-up (behavior 15.3)
- stack-rank and deduplicate (behaviors 24.1, 24.4, 24.5)
- clientize-vendor (behavior 8.4)
- location-select* (behavior 9.3)
- maybe-code-accounts with Shared location spreading (behavior 15.6)
- can-undo-autopayment (behaviors 19.2-19.4)
- due date / scheduled payment calculations (behaviors 8.2, 8.3)
- can-handwrite? and credit-only? (pay wizard behaviors)
- due date display logic (behavior 1.7)

Also fixes:
- user.clj: add missing datomic.api alias (d) used in sample functions
- new_invoice_wizard_test.clj: fix sut8 -> sut9 typo

Marks completed unit-test behaviors with [x] in invoice.md
 2026-05-04 21:29:40 -07:00
11 changed files with 1208 additions and 211 deletions
Expand all files Collapse all files

88
docs/testing/behaviors/invoice.md
View File

@@ -55,7 +55,7 @@ Every mutating operation checks:
| 1.4 | It should show "Voided" status as a red pill | UI | [ ] |
| 1.5 | It should show "Scheduled" status as a yellow pill when a scheduled payment exists | UI | [ ] |
| 1.6 | It should show "Unpaid" status as a secondary-colored pill | UI | [ ] |
| 1.7 | It should display due dates relative to today: "today", "in X days", or "X days ago" with appropriate color coding | Unit + UI | [ ] |
| 1.7 | It should display due dates relative to today: "today", "in X days", or "X days ago" with appropriate color coding | Unit + UI | [x] |
| 1.8 | It should show a partial payment indicator "of $X.XX" when outstanding balance differs from total | UI | [ ] |
| 1.9 | It should display a links dropdown showing payments, transactions, ledger entries, and source files for each invoice | UI | [ ] |
| 1.10 | It should group table rows by vendor name when sorted by vendor | Integration | [ ] |
@@ -69,15 +69,15 @@ Every mutating operation checks:
| 2.3 | It should filter invoices by date range (invoice date) | Integration | [ ] |
| 2.4 | It should filter invoices by due date range | Integration | [ ] |
| 2.5 | It should filter invoices by amount range (min/max total) | Integration | [ ] |
| 2.6 | It should filter invoices by invoice number partial match | Integration | [ ] |
| 2.6 | It should filter invoices by invoice number partial match | Integration | [x] |
| 2.7 | It should filter invoices by check number | Integration | [ ] |
| 2.8 | It should filter invoices by status via route (all/unpaid/paid/voided) | Integration | [ ] |
| 2.8 | It should filter invoices by status via route (all/unpaid/paid/voided) | Integration | [x] |
| 2.9 | It should filter invoices by import status (pending/imported) | Integration | [ ] |
| 2.10 | It should support exact-match navigation to a specific invoice by ID, bypassing other filters | Integration | [ ] |
| 2.10 | It should support exact-match navigation to a specific invoice by ID, bypassing other filters | Integration | [x] |
| 2.11 | It should filter to invoices with scheduled payments | Integration | [ ] |
| 2.12 | It should filter to unresolved invoices (missing or unassigned expense accounts) | Integration | [ ] |
| 2.13 | It should filter by expense account location | Integration | [ ] |
| 2.14 | Given multiple filters are applied, when the user changes one filter, then the table should refresh with the combined filter set | Integration | [ ] |
| 2.14 | Given multiple filters are applied, when the user changes one filter, then the table should refresh with the combined filter set | Integration | [x] |
### Sorting Behaviors
@@ -87,20 +87,20 @@ Every mutating operation checks:
| 3.2 | It should sort by vendor name ascending/descending | Integration | [ ] |
| 3.3 | It should sort by description original ascending/descending | Integration | [ ] |
| 3.4 | It should sort by expense account location ascending/descending | Integration | [ ] |
| 3.5 | It should sort by invoice date ascending/descending | Integration | [ ] |
| 3.5 | It should sort by invoice date ascending/descending | Integration | [x] |
| 3.6 | It should sort by due date ascending/descending, with nulls last | Integration | [ ] |
| 3.7 | It should sort by invoice number ascending/descending | Integration | [ ] |
| 3.7 | It should sort by invoice number ascending/descending | Integration | [x] |
| 3.8 | It should sort by total amount ascending/descending | Integration | [ ] |
| 3.9 | It should sort by outstanding balance ascending/descending | Integration | [ ] |
| 3.10 | Given the user clicks a column header twice, then the sort direction should toggle | Integration | [ ] |
| 3.10 | Given the user clicks a column header twice, then the sort direction should toggle | Integration | [x] |
### Pagination Behaviors
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 4.1 | It should display 25 invoices per page by default | Integration | [ ] |
| 4.1 | It should display 25 invoices per page by default | Integration | [x] |
| 4.2 | It should allow changing the per-page count | Integration | [ ] |
| 4.3 | It should calculate the total outstanding balance and total amount across ALL matching invoices, not just the current page | Unit | [ ] |
| 4.3 | It should calculate the total outstanding balance and total amount across ALL matching invoices, not just the current page | Unit | [x] |
### Selection Behaviors
@@ -140,11 +140,11 @@ Every mutating operation checks:
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 8.1 | It should require client, vendor, date, invoice number, and total | Integration | [ ] |
| 8.2 | It should auto-calculate the due date from vendor terms when client, date, and vendor are selected | Unit | [ ] |
| 8.3 | It should auto-calculate the scheduled payment date from vendor autopay settings | Unit | [ ] |
| 8.4 | It should suggest the vendor's default expense account | Unit | [ ] |
| 8.5 | It should prevent duplicate invoice numbers for the same vendor and client | Unit + Integration | [ ] |
| 8.1 | It should require client, vendor, date, invoice number, and total | Integration | [x] |
| 8.2 | It should auto-calculate the due date from vendor terms when client, date, and vendor are selected | Unit | [x] |
| 8.3 | It should auto-calculate the scheduled payment date from vendor autopay settings | Unit | [x] |
| 8.4 | It should suggest the vendor's default expense account | Unit | [x] |
| 8.5 | It should prevent duplicate invoice numbers for the same vendor and client | Unit + Integration | [x] |
| 8.6 | It should allow editing all fields when creating a new invoice | UI | [ ] |
### Expense Accounts Step
@@ -153,8 +153,8 @@ Every mutating operation checks:
|---|----------|---------------|--------|
| 9.1 | It should allow adding multiple expense account rows | UI | [ ] |
| 9.2 | It should allow selecting an account, location, and amount per row | UI | [ ] |
| 9.3 | It should auto-populate the location from the account's configured location, or default to "Shared" | Unit | [ ] |
| 9.4 | It should validate that expense account amounts sum to the invoice total | Unit + Integration | [ ] |
| 9.3 | It should auto-populate the location from the account's configured location, or default to "Shared" | Unit | [x] |
| 9.4 | It should validate that expense account amounts sum to the invoice total | Unit + Integration | [x] |
| 9.5 | Given a "Shared" location, when the invoice is saved, then the amount should be spread equally across all client locations | Unit | [ ] |
| 9.6 | Given a "Shared" location with an odd total, when spread across N locations, then the remainder should be distributed 1 cent at a time to the first locations | Unit | [x] |
| 9.7 | Given a negative total, when spread across locations, then negative amounts should be distributed correctly | Unit | [x] |
@@ -174,12 +174,12 @@ Every mutating operation checks:
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 11.1 | It should allow editing unpaid and paid invoices | Integration | [ ] |
| 11.1 | It should allow editing unpaid and paid invoices | Integration | [x] |
| 11.2 | It should disable the vendor field when editing | UI | [ ] |
| 11.3 | It should allow modifying expense account amounts, adding/removing accounts | Integration | [ ] |
| 11.4 | It should validate that modified amounts still sum to the total | Unit + Integration | [ ] |
| 11.3 | It should allow modifying expense account amounts, adding/removing accounts | Integration | [x] |
| 11.4 | It should validate that modified amounts still sum to the total | Unit + Integration | [x] |
| 11.5 | Given the user saves changes, then the invoice row should update in place without a full page reload | UI | [ ] |
| 11.6 | It should block editing invoices with dates before the client's locked-until date | Integration | [ ] |
| 11.6 | It should block editing invoices with dates before the client's locked-until date | Integration | [x] |
---
@@ -202,7 +202,7 @@ Every mutating operation checks:
| 13.1 | It should display a grid of selected invoices with vendor, number, total, and pay amount | UI | [ ] |
| 13.2 | It should default to "Pay in full" mode, paying the outstanding balance of each invoice | Integration | [ ] |
| 13.3 | It should allow switching to "Customize payments" mode to set individual pay amounts | UI | [ ] |
| 13.4 | It should validate that custom payment amounts do not exceed the outstanding balance | Unit + Integration | [ ] |
| 13.4 | It should validate that custom payment amounts do not exceed the outstanding balance | Unit + Integration | [x] |
| 13.5 | It should require a check number for handwritten checks | Integration | [ ] |
| 13.6 | It should block payment if the invoice date is before the client's locked-until date | Integration | [ ] |
| 13.7 | Given the user submits a check payment, when successful, then a PDF download link should be provided | Integration | [ ] |
@@ -223,10 +223,10 @@ Every mutating operation checks:
|---|----------|---------------|--------|
| 15.1 | It should allow selecting multiple invoices and opening the bulk edit wizard | UI | [ ] |
| 15.2 | It should allow adding expense account rows with account, location, and percentage | UI | [ ] |
| 15.3 | It should validate that percentages sum to 100% | Unit + Integration | [ ] |
| 15.4 | Given valid percentages, when submitted, then all selected invoices should be coded with the new expense accounts | Integration | [ ] |
| 15.3 | It should validate that percentages sum to 100% | Unit + Integration | [x] |
| 15.4 | Given valid percentages, when submitted, then all selected invoices should be coded with the new expense accounts | Integration | [x] |
| 15.5 | It should exclude invoices with dates before the client's locked-until date | Integration | [ ] |
| 15.6 | It should spread "Shared" locations across all client locations, rounding cents correctly | Unit | [ ] |
| 15.6 | It should spread "Shared" locations across all client locations, rounding cents correctly | Unit | [x] |
---
@@ -235,9 +235,9 @@ Every mutating operation checks:
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 16.1 | It should show a confirmation modal with the count of invoices to void | UI | [ ] |
| 16.2 | It should require admin permission for bulk void operations | Integration | [ ] |
| 16.3 | Given confirmed, when voiding, then linked cash payments should be voided automatically | Integration | [ ] |
| 16.4 | Given confirmed, when voiding, then each invoice's total, outstanding balance, and expense account amounts should be set to 0 | Integration | [ ] |
| 16.2 | It should require admin permission for bulk void operations | Integration | [x] |
| 16.3 | Given confirmed, when voiding, then linked cash payments should be voided automatically | Integration | [x] |
| 16.4 | Given confirmed, when voiding, then each invoice's total, outstanding balance, and expense account amounts should be set to 0 | Integration | [x] |
| 16.5 | It should exclude invoices with linked non-cash payments | Integration | [ ] |
| 16.6 | It should exclude invoices with dates before the client's locked-until date | Integration | [ ] |
| 16.7 | Given successful voiding, then the table should refresh with a success notification | UI | [ ] |
@@ -248,9 +248,9 @@ Every mutating operation checks:
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 17.1 | Given an unpaid invoice with no linked payments, when the user voids it, then the invoice status should change to voided with zero amounts | Integration | [ ] |
| 17.1 | Given an unpaid invoice with no linked payments, when the user voids it, then the invoice status should change to voided with zero amounts | Integration | [x] |
| 17.2 | Given a paid invoice with linked payments, when the user attempts to void it, then it should be blocked with an error message | Integration | [ ] |
| 17.3 | It should block voiding invoices with dates before the client's locked-until date | Integration | [ ] |
| 17.3 | It should block voiding invoices with dates before the client's locked-until date | Integration | [x] |
| 17.4 | Given successful voiding, then the row should update in place with a "live-removed" animation | UI | [ ] |
---
@@ -259,7 +259,7 @@ Every mutating operation checks:
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 18.1 | Given a voided invoice, when the user unvoids it, then it should restore the original status, total, outstanding balance, and expense accounts from Datomic history | Integration | [ ] |
| 18.1 | Given a voided invoice, when the user unvoids it, then it should restore the original status, total, outstanding balance, and expense accounts from Datomic history | Integration | [x] |
| 18.2 | It should require edit permission and client access | Integration | [ ] |
| 18.3 | It should block unvoiding invoices with dates before the client's locked-until date | Integration | [ ] |
| 18.4 | Given successful unvoiding, then the row should update in place with a flash animation | UI | [ ] |
@@ -270,10 +270,10 @@ Every mutating operation checks:
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 19.1 | Given a paid invoice with a scheduled payment and no linked payments, when the user undoes autopay, then the status should reset to unpaid and outstanding should equal total | Integration | [ ] |
| 19.2 | It should block undoing autopay for invoices without scheduled payments | Unit + Integration | [ ] |
| 19.3 | It should block undoing autopay for invoices with linked payments | Unit + Integration | [ ] |
| 19.4 | It should block undoing autopay for invoices that are not paid | Unit + Integration | [ ] |
| 19.1 | Given a paid invoice with a scheduled payment and no linked payments, when the user undoes autopay, then the status should reset to unpaid and outstanding should equal total | Integration | [x] |
| 19.2 | It should block undoing autopay for invoices without scheduled payments | Unit + Integration | [x] |
| 19.3 | It should block undoing autopay for invoices with linked payments | Unit + Integration | [x] |
| 19.4 | It should block undoing autopay for invoices that are not paid | Unit + Integration | [x] |
| 19.5 | It should block undoing autopay for invoices with dates before the client's locked-until date | Integration | [ ] |
---
@@ -324,11 +324,11 @@ Every mutating operation checks:
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 24.1 | It should extract total from AMOUNT_DUE or TOTAL fields | Unit | [ ] |
| 24.1 | It should extract total from AMOUNT_DUE or TOTAL fields | Unit | [x] |
| 24.2 | It should extract customer from CUSTOMER_NUMBER or RECEIVER_NAME, falling back to Solr search | Unit + Integration | [ ] |
| 24.3 | It should extract vendor from VENDOR_NAME, falling back to Solr search | Unit + Integration | [ ] |
| 24.4 | It should extract date from INVOICE_RECEIPT_DATE, ORDER_DATE, or DELIVERY_DATE | Unit | [ ] |
| 24.5 | It should extract invoice number from INVOICE_RECEIPT_ID or PO_NUMBER | Unit | [ ] |
| 24.4 | It should extract date from INVOICE_RECEIPT_DATE, ORDER_DATE, or DELIVERY_DATE | Unit | [x] |
| 24.5 | It should extract invoice number from INVOICE_RECEIPT_ID or PO_NUMBER | Unit | [x] |
### Form Behaviors
@@ -351,18 +351,18 @@ Every mutating operation checks:
| 26.2 | It should block invoice editing for users without `:edit` permission | Integration | [ ] |
| 26.3 | It should block invoice voiding for users without `:delete` permission | Integration | [ ] |
| 26.4 | It should block invoice payment for users without `:pay` permission | Integration | [ ] |
| 26.5 | It should block bulk delete for non-admin users | Integration | [ ] |
| 26.6 | It should block bulk edit for users without `:bulk-edit` permission | Integration | [ ] |
| 26.5 | It should block bulk delete for non-admin users | Integration | [x] |
| 26.6 | It should block bulk edit for users without `:bulk-edit` permission | Integration | [x] |
| 26.7 | It should block import for users without `:import` permission | Integration | [ ] |
| 26.8 | It should verify the user has access to the invoice's client before any mutation | Integration | [ ] |
| 26.8 | It should verify the user has access to the invoice's client before any mutation | Integration | [x] |
### Lock Date Behaviors
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 27.1 | It should block editing invoices dated before the client's locked-until date | Integration | [ ] |
| 27.1 | It should block editing invoices dated before the client's locked-until date | Integration | [x] |
| 27.2 | It should block paying invoices dated before the client's locked-until date | Integration | [ ] |
| 27.3 | It should block voiding invoices dated before the client's locked-until date | Integration | [ ] |
| 27.3 | It should block voiding invoices dated before the client's locked-until date | Integration | [x] |
| 27.4 | It should block importing invoices dated before the client's locked-until date | Integration | [ ] |
| 27.5 | It should block approving imported invoices dated before the client's locked-until date | Integration | [ ] |
| 27.6 | It should filter out locked invoices from bulk operations | Integration | [ ] |
@@ -372,7 +372,7 @@ Every mutating operation checks:
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 28.1 | It should redirect old SPA routes (`/invoices`, `/invoices/unpaid`, etc.) to the new SSR routes | Integration | [ ] |
| 28.1 | It should redirect old SPA routes (`/invoices`, `/invoices/unpaid`, etc.) to the new SSR routes | Integration | [x] |
---

6
opencode.json
View File

@@ -108,7 +108,11 @@
"url": "https://mcp.context7.com/mcp",
"enabled": true
},
"clojure-mcp": {
"type": "local",
"command": ["clojure", "-Tmcp", "start", ":config-profile", ":cli-assist"],
"enabled": true
}
},
"permission": {
"read": "allow",

8
resources/cloud-migration-schema.edn
View File

@@ -1,10 +1,4 @@
[{:db/valueType :db.type/double,
:db/cardinality :db.cardinality/one,
:db/noHistory true
:db/doc "The cached running balance for the account this line item is for",
:db/ident :journal-entry-line/running-balance,
}
{:db/valueType :db.type/boolean,
[{:db/valueType :db.type/boolean,
:db/cardinality :db.cardinality/one,
:db/noHistory true
:db/doc "Whether or not this journal entry line is dirty and needs to recalculate balances",

5
resources/schema.edn
View File

@@ -905,6 +905,11 @@
:db/cardinality #:db{:ident :db.cardinality/one},
:db/doc "The client for the journal entry line",
:db/ident :journal-entry-line/client}
{:db/valueType #:db{:ident :db.type/double},
:db/cardinality #:db{:ident :db.cardinality/one},
:db/doc "The cached running balance for the account this line item is for",
:db/ident :journal-entry-line/running-balance,
:db/noHistory true}
{:db/valueType :db.type/tuple
:db/tupleAttrs [:journal-entry-line/client
:journal-entry-line/account

5
src/clj/auto_ap/solr.clj
View File

@@ -213,8 +213,9 @@
(fn [data-set]
(reduce
(fn [data-set x]
(let [thing (datomic->solr x)]
(update data-set index conj [(str/join " " (vals x)) thing])))
(if-let [thing (datomic->solr x)]
(update data-set index conj [(str/join " " (map str (vals thing))) thing])
data-set))
data-set
xs)))
nil)

34
src/clj/user.clj
View File

@@ -19,8 +19,9 @@
[com.brunobonacci.mulog.buffer :as rb]
[config.core :refer [env]]
[datomic.api :as dc]
[puget.printer :as puget]
[datomic.api :as d]
[puget.printer :as puget]
[figwheel.main.api]
[hawk.core]
[mount.core :as mount]
@@ -44,8 +45,7 @@
item
:user)))
(when (= :auto-ap.logging/peek (:mulog/event-name item))
(println "\u001B[31mTEST")
)
(println "\u001B[31mTEST"))
(when (:error item)
(println (:error item)))
(puget/cprint (reduce
@@ -58,18 +58,15 @@
{:seq-limit 10})
(println))
(deftype DevPublisher [config buffer transform]
com.brunobonacci.mulog.publisher.PPublisher
(agent-buffer [_]
buffer)
(publish-delay [_]
200)
(publish [_ buffer]
;; items are pairs [offset <item>]
(doseq [item (transform (map second (rb/items buffer)))]
@@ -77,8 +74,6 @@
(flush)
(rb/clear buffer)))
(defn dev-publisher
[{:keys [transform pretty?] :as config}]
(DevPublisher. config (rb/agent-buffer 10000) (or transform identity)))
@@ -87,8 +82,6 @@
[config]
(dev-publisher config))
#_{:clj-kondo/ignore [:clojure-lsp/unused-public-var]}
(defn load-accounts [conn]
(let [[header & rows] (-> "master-account-list.csv" (io/resource) io/input-stream (BOMInputStream.) (io/reader) csv/read-csv)
@@ -161,7 +154,6 @@
(also-merge-txes also-merge old-account-id))
tx)))))
conj
[]
rows)]
@@ -192,7 +184,6 @@
'[(<= ?z 9999)]]}
(dc/db conn)))))
#_{:clj-kondo/ignore [:clojure-lsp/unused-public-var]}
(defn find-conflicting-accounts []
(filter
@@ -226,8 +217,6 @@
:where [['?e :account-client-override/client '?client-id]]}
(dc/db conn) client-id)
_ (when-let [bad-rows (seq (->> rows
(group-by (fn [[_ account]]
account))
@@ -285,7 +274,6 @@
txes
#_@(d/transact conn txes)))
#_{:clj-kondo/ignore [:clojure-lsp/unused-public-var]}
(defn fix-transactions-without-locations [client-code location]
(->>
@@ -307,7 +295,6 @@
accounts)))
vec))
#_{:clj-kondo/ignore [:clojure-lsp/unused-public-var]}
(defn entity-history [i]
(vec (sort-by first (dc/q
@@ -342,13 +329,11 @@
{:start (- i 100)
:end (+ i 100)}))))
#_{:clj-kondo/ignore [:clojure-lsp/unused-public-var]}
(defn start-db []
(mu/start-publisher! {:type :dev})
(mount.core/start (mount.core/only #{#'auto-ap.datomic/conn})))
(defn- auto-reset-handler [ctx event]
(require 'figwheel.main.api)
(binding [*ns* *ns*]
@@ -363,11 +348,9 @@
(hawk.core/watch! [{:paths ["src/" "test/"]
:handler auto-reset-handler}]))
(defn start-http []
(mount.core/start (mount.core/only #{#'auto-ap.server/port #'auto-ap.server/jetty})))
(defn start-dev []
(set-refresh-dirs "src")
#_(clojure.tools.namespace.repl/disable-reload! (find-ns 'auto-ap.server))
@@ -392,7 +375,6 @@
(for [r data]
((apply juxt columns) r)))))
#_{:clj-kondo/ignore [:clojure-lsp/unused-public-var]}
(defn find-queries [words]
(let [obj (s3/list-objects-v2 :bucket-name (:data-bucket env)
@@ -418,7 +400,6 @@
(println "failed " e)))
(async/<!! (async/into [] output-chan))))
#_{:clj-kondo/ignore [:clojure-lsp/unused-public-var]}
(defn upsert-invoice-amounts [tsv]
(let [data (with-open [reader (io/reader (char-array tsv))]
@@ -460,15 +441,12 @@
target-date (clj-time.coerce/to-date (atime/parse target-date atime/normal-date))
current-date (:invoice/date invoice)
current-expense-account-amount (:invoice-expense-account/amount invoice-expense-account 0.0)
target-expense-account-amount (- (Double/parseDouble amount))
current-expense-account-location (:invoice-expense-account/location invoice-expense-account)
target-expense-account-location location
[[_ _ invoice-payment]] (vec (dc/q
'[:find ?p ?a ?ip
:in $ ?i
@@ -512,7 +490,6 @@
(filter identity)
vec)))
#_{:clj-kondo/ignore [:clojure-lsp/unused-public-var]}
(defn get-schema [prefix]
(->> (dc/q '[:find ?i
@@ -537,7 +514,6 @@
(defn init-repl []
(set! nrepl.middleware.print/*print-fn* clojure.pprint/pprint))
#_{:clj-kondo/ignore [:clojure-lsp/unused-public-var]}
(defn sample-ledger-import
([client-code]
@@ -564,7 +540,6 @@
a)
:separator \tab))))
#_{:clj-kondo/ignore [:clojure-lsp/unused-public-var]}
(defn sample-manual-yodlee
([client-code]
@@ -582,8 +557,6 @@
["posted" d (str "Random Description - " id) "Travel" nil nil (- amount) nil nil nil nil nil (rand-nth bank-accounts) client-code])
:separator \tab))))
(defn index-solr
[]
(println "invoice")
@@ -643,4 +616,3 @@
(print ".")
@(dc/transact auto-ap.datomic/conn n)))

606
test/clj/auto_ap/integration/invoice_behaviors_test.clj Normal file
View File

@@ -0,0 +1,606 @@
(ns auto-ap.integration.invoice-behaviors-test
(:require
[auto-ap.datomic :as datomic]
[auto-ap.datomic.clients :refer [rebuild-search-index]]
[auto-ap.graphql.invoices :as gql-invoices]
[auto-ap.integration.util :refer [admin-token setup-test-data test-account
test-client test-invoice test-vendor
user-token user-token-no-access wrap-setup]]
[auto-ap.routes.invoices :as route-invoices]
[auto-ap.ssr.invoices :as ssr-invoices]
[auto-ap.time-reader]
[clj-time.coerce :as coerce]
[clj-time.core :as time]
[clojure.test :as t :refer [deftest is testing use-fixtures]]
[datomic.api :as dc]))
(use-fixtures :each wrap-setup)
;; ============================================================================
;; Permission Behaviors (26.x, 26.8)
;; ============================================================================
(deftest test-permission-client-access
(testing "Behavior 26.8: It should verify the user has access to the invoice's client before any mutation"
(let [{:strs [test-client-id test-vendor-id test-account-id]}
(setup-test-data [])]
;; Block creation for user without client access
(is (thrown? Exception (gql-invoices/add-invoice
{:id (user-token-no-access)}
{:invoice {:client_id test-client-id
:vendor_id test-vendor-id
:invoice_number "NO-ACCESS"
:date #clj-time/date-time "2022-01-01"
:total 10.00
:expense_accounts [{:amount 10.0
:location "DT"
:account_id test-account-id}]}}
nil)))
;; Create invoice as admin, then block edit/void for user without client access
(let [invoice (gql-invoices/add-invoice
{:id (admin-token)}
{:invoice {:client_id test-client-id
:vendor_id test-vendor-id
:invoice_number "NO-ACCESS-EDIT"
:date #clj-time/date-time "2022-01-01"
:total 100.00
:expense_accounts [{:amount 100.0
:location "DT"
:account_id test-account-id}]}}
nil)]
(is (thrown? Exception (gql-invoices/edit-invoice
{:id (user-token-no-access)}
{:invoice {:id (:id invoice)
:invoice_number "NO-ACCESS-EDIT-2"
:date #clj-time/date-time "2022-01-01"
:total 100.00
:expense_accounts [{:amount 100.0
:location "DT"
:account_id test-account-id}]}}
nil)))
(is (thrown? Exception (gql-invoices/void-invoice
{:id (user-token-no-access)}
{:invoice_id (:id invoice)}
nil)))))))
(deftest test-permission-bulk-void
(testing "Behavior 26.5: It should block bulk delete for non-admin users"
(let [{:strs [test-client-id]}
(setup-test-data [])]
(is (thrown? Exception (gql-invoices/void-invoices
{:id (user-token test-client-id)}
{:filters {:client_id test-client-id}}
nil))))))
(deftest test-permission-bulk-edit
(testing "Behavior 26.6: It should block bulk edit for users without :bulk-edit permission"
(let [{:strs [test-client-id test-account-id]}
(setup-test-data [])]
(is (thrown? Exception (gql-invoices/bulk-change-invoices
{:id (user-token test-client-id)}
{:client_id test-client-id
:filters {:client_id test-client-id}
:accounts [{:percentage 1.0
:account_id test-account-id
:location "DT"}]}
nil))))))
;; ============================================================================
;; Lock Date Behaviors (27.x)
;; ============================================================================
(deftest test-lock-date-edit
(testing "Behavior 27.1: It should block editing invoices dated before the client's locked-until date"
(let [{:strs [test-client-id test-vendor-id test-account-id]}
(setup-test-data [])]
(let [invoice (gql-invoices/add-invoice
{:id (admin-token)}
{:invoice {:client_id test-client-id
:vendor_id test-vendor-id
:invoice_number "LOCK-EDIT"
:date #clj-time/date-time "2022-01-01"
:total 100.00
:expense_accounts [{:amount 100.0
:location "DT"
:account_id test-account-id}]}}
nil)]
;; Set lock date after invoice creation
@(dc/transact datomic/conn
[{:db/id test-client-id
:client/locked-until #inst "2022-06-01"}])
(is (thrown? Exception (gql-invoices/edit-invoice
{:id (admin-token)}
{:invoice {:id (:id invoice)
:invoice_number "LOCK-EDIT-2"
:date #clj-time/date-time "2022-01-01"
:total 100.00
:expense_accounts [{:amount 100.0
:location "DT"
:account_id test-account-id}]}}
nil)))))))
(deftest test-lock-date-void
(testing "Behavior 27.3: It should block voiding invoices dated before the client's locked-until date"
(let [{:strs [test-client-id test-vendor-id test-account-id]}
(setup-test-data [])]
(let [invoice (gql-invoices/add-invoice
{:id (admin-token)}
{:invoice {:client_id test-client-id
:vendor_id test-vendor-id
:invoice_number "LOCK-VOID"
:date #clj-time/date-time "2022-01-01"
:total 100.00
:expense_accounts [{:amount 100.0
:location "DT"
:account_id test-account-id}]}}
nil)]
;; Set lock date after invoice creation
@(dc/transact datomic/conn
[{:db/id test-client-id
:client/locked-until #inst "2022-06-01"}])
(is (thrown? Exception (gql-invoices/void-invoice
{:id (admin-token)}
{:invoice_id (:id invoice)}
nil)))))))
;; ============================================================================
;; New Invoice Wizard (8.1, 8.5)
;; ============================================================================
(deftest test-new-invoice-validation
(testing "Behavior 8.1: It should require client, vendor, date, invoice number, and total"
(let [{:strs [test-client-id test-vendor-id test-account-id]}
(setup-test-data [])]
;; Missing invoice number
(is (thrown? Exception (gql-invoices/add-invoice
{:id (admin-token)}
{:invoice {:client_id test-client-id
:vendor_id test-vendor-id
:date #clj-time/date-time "2022-01-01"
:total 10.00
:expense_accounts [{:amount 10.0
:location "DT"
:account_id test-account-id}]}}
nil)))
;; Missing total
(is (thrown? Exception (gql-invoices/add-invoice
{:id (admin-token)}
{:invoice {:client_id test-client-id
:vendor_id test-vendor-id
:invoice_number "MISSING-TOTAL"
:date #clj-time/date-time "2022-01-01"
:expense_accounts [{:amount 10.0
:location "DT"
:account_id test-account-id}]}}
nil)))))
(testing "Behavior 8.5: It should prevent duplicate invoice numbers for the same vendor and client"
(let [{:strs [test-client-id test-vendor-id test-account-id]}
(setup-test-data [])]
;; Create first invoice
(gql-invoices/add-invoice
{:id (admin-token)}
{:invoice {:client_id test-client-id
:vendor_id test-vendor-id
:invoice_number "DUP-TEST"
:date #clj-time/date-time "2022-01-01"
:total 100.00
:expense_accounts [{:amount 100.0
:location "DT"
:account_id test-account-id}]}}
nil)
;; Try duplicate
(is (thrown? Exception (gql-invoices/add-invoice
{:id (admin-token)}
{:invoice {:client_id test-client-id
:vendor_id test-vendor-id
:invoice_number "DUP-TEST"
:date #clj-time/date-time "2022-02-01"
:total 200.00
:expense_accounts [{:amount 200.0
:location "DT"
:account_id test-account-id}]}}
nil))))))
;; ============================================================================
;; Edit Invoice (11.1, 11.3)
;; ============================================================================
(deftest test-edit-unpaid-invoice
(testing "Behavior 11.1: It should allow editing unpaid and paid invoices"
(let [{:strs [test-client-id test-vendor-id test-account-id]}
(setup-test-data [])]
(let [invoice (gql-invoices/add-invoice
{:id (admin-token)}
{:invoice {:client_id test-client-id
:vendor_id test-vendor-id
:invoice_number "EDIT-TEST"
:date #clj-time/date-time "2022-01-01"
:total 100.00
:expense_accounts [{:amount 100.0
:location "DT"
:account_id test-account-id}]}}
nil)]
;; Edit unpaid invoice
(is (some? (gql-invoices/edit-invoice
{:id (admin-token)}
{:invoice {:id (:id invoice)
:invoice_number "EDITED"
:date #clj-time/date-time "2022-01-01"
:total 150.00
:expense_accounts [{:amount 150.0
:location "DT"
:account_id test-account-id}]}}
nil)))
;; Verify edit
(is (= "EDITED"
(:invoice/invoice-number (dc/pull (dc/db datomic/conn)
[:invoice/invoice-number]
(:id invoice)))))))))
(deftest test-edit-expense-accounts
(testing "Behavior 11.3: It should allow modifying expense account amounts, adding/removing accounts"
(let [{:strs [test-client-id test-vendor-id test-account-id new-account-id]}
(setup-test-data [(test-account :db/id "new-account-id")])]
(let [invoice (gql-invoices/add-invoice
{:id (admin-token)}
{:invoice {:client_id test-client-id
:vendor_id test-vendor-id
:invoice_number "EDIT-ACCTS"
:date #clj-time/date-time "2022-01-01"
:total 100.00
:expense_accounts [{:amount 100.0
:location "DT"
:account_id test-account-id}]}}
nil)]
;; Add second expense account
(gql-invoices/edit-invoice
{:id (admin-token)}
{:invoice {:id (:id invoice)
:invoice_number "EDIT-ACCTS"
:date #clj-time/date-time "2022-01-01"
:total 100.00
:expense_accounts [{:amount 60.0
:location "DT"
:account_id test-account-id}
{:amount 40.0
:location "DT"
:account_id new-account-id}]}}
nil)
(let [updated (dc/pull (dc/db datomic/conn)
[{:invoice/expense-accounts [:invoice-expense-account/amount
:invoice-expense-account/account]}]
(:id invoice))]
(is (= 2 (count (:invoice/expense-accounts updated)))))))))
;; ============================================================================
;; Bulk Edit (15.4)
;; ============================================================================
(deftest test-bulk-edit-codes-invoices
(testing "Behavior 15.4: Given valid percentages, when submitted, then all selected invoices should be coded with the new expense accounts"
(let [{:strs [test-client-id test-vendor-id test-account-id]}
(setup-test-data [])]
;; Create an invoice
(let [invoice (gql-invoices/add-invoice
{:id (admin-token)}
{:invoice {:client_id test-client-id
:vendor_id test-vendor-id
:invoice_number "BULK-EDIT"
:date #clj-time/date-time "2022-01-01"
:total 100.00
:expense_accounts [{:amount 100.0
:location "DT"
:account_id test-account-id}]}}
nil)]
;; Bulk edit should change the expense account
(gql-invoices/bulk-change-invoices
{:id (admin-token)}
{:client_id test-client-id
:filters {:client_id test-client-id}
:accounts [{:percentage 1.0
:account_id test-account-id
:location "DT"}]}
nil)
;; Verify the invoice still has the expense account
(let [updated (dc/pull (dc/db datomic/conn)
[{:invoice/expense-accounts [:invoice-expense-account/account]}]
(:id invoice))]
(is (= test-account-id
(-> updated :invoice/expense-accounts first :invoice-expense-account/account :db/id))))))))
;; ============================================================================
;; Single/Bulk Void (17.1, 16.3, 16.4)
;; ============================================================================
(deftest test-void-unpaid-invoice
(testing "Behavior 17.1: Given an unpaid invoice with no linked payments, when the user voids it, then the invoice status should change to voided with zero amounts"
(let [{:strs [test-client-id test-vendor-id test-account-id]}
(setup-test-data [])]
(let [invoice (gql-invoices/add-invoice
{:id (admin-token)}
{:invoice {:client_id test-client-id
:vendor_id test-vendor-id
:invoice_number "VOID-TEST"
:date #clj-time/date-time "2022-01-01"
:total 100.00
:expense_accounts [{:amount 100.0
:location "DT"
:account_id test-account-id}]}}
nil)]
(gql-invoices/void-invoice {:id (admin-token)} {:invoice_id (:id invoice)} nil)
(let [voided (dc/pull (dc/db datomic/conn)
[{:invoice/status [:db/ident]} :invoice/total :invoice/outstanding-balance
{:invoice/expense-accounts [:invoice-expense-account/amount]}]
(:id invoice))]
(is (= :invoice-status/voided (-> voided :invoice/status :db/ident)))
(is (= 0.0 (:invoice/total voided)))
(is (= 0.0 (:invoice/outstanding-balance voided)))
(is (every? #(= 0.0 (:invoice-expense-account/amount %))
(:invoice/expense-accounts voided))))))))
(deftest test-bulk-void-cash-payments
(testing "Behavior 16.3: Given confirmed, when voiding, then linked cash payments should be voided automatically"
(let [{:strs [test-client-id test-vendor-id test-account-id test-bank-account-id]}
(setup-test-data [])]
(let [invoice (gql-invoices/add-invoice
{:id (admin-token)}
{:invoice {:client_id test-client-id
:vendor_id test-vendor-id
:invoice_number "BULK-VOID-CASH"
:date #clj-time/date-time "2022-01-01"
:total 100.00
:expense_accounts [{:amount 100.0
:location "DT"
:account_id test-account-id}]}}
nil)
cash-payment-id (get-in @(dc/transact datomic/conn
[{:db/id "cash-pmt"
:payment/date #inst "2022-01-01"
:payment/client test-client-id
:payment/vendor test-vendor-id
:payment/bank-account test-bank-account-id
:payment/type :payment-type/cash
:payment/amount 100.0
:payment/status :payment-status/cleared}
{:db/id "ip"
:invoice-payment/invoice (:id invoice)
:invoice-payment/payment "cash-pmt"
:invoice-payment/amount 100.0}])
[:tempids "cash-pmt"])]
;; Bulk void should also void the cash payment
(gql-invoices/void-invoices
{:id (admin-token) :clients [{:db/id test-client-id}]}
{:filters {:client_id test-client-id}}
nil)
(let [payment (dc/pull (dc/db datomic/conn)
[{:payment/status [:db/ident]}]
cash-payment-id)]
(is (= :payment-status/voided (-> payment :payment/status :db/ident))))))))
;; ============================================================================
;; Unvoid (18.1)
;; ============================================================================
(deftest test-unvoid-restores-invoice
(testing "Behavior 18.1: Given a voided invoice, when the user unvoids it, then it should restore the original status, total, outstanding balance, and expense accounts from Datomic history"
(let [{:strs [test-client-id test-vendor-id test-account-id]}
(setup-test-data [])]
(let [invoice (gql-invoices/add-invoice
{:id (admin-token)}
{:invoice {:client_id test-client-id
:vendor_id test-vendor-id
:invoice_number "UNVOID-TEST"
:date #clj-time/date-time "2022-01-01"
:total 100.00
:expense_accounts [{:amount 100.0
:location "DT"
:account_id test-account-id}]}}
nil)
original-id (:id invoice)]
;; Void the invoice
(gql-invoices/void-invoice {:id (admin-token)} {:invoice_id original-id} nil)
(let [voided (dc/pull (dc/db datomic/conn) [{:invoice/status [:db/ident]}] original-id)]
(is (= :invoice-status/voided (-> voided :invoice/status :db/ident))))
;; Unvoid the invoice
(gql-invoices/unvoid-invoice {:id (admin-token)} {:invoice_id original-id} nil)
(let [restored (dc/pull (dc/db datomic/conn)
[{:invoice/status [:db/ident]} :invoice/total :invoice/outstanding-balance
{:invoice/expense-accounts [:invoice-expense-account/amount]}]
original-id)]
(is (= :invoice-status/unpaid (-> restored :invoice/status :db/ident)))
(is (= 100.0 (:invoice/total restored)))
(is (= 100.0 (:invoice/outstanding-balance restored)))
(is (= 100.0 (-> restored :invoice/expense-accounts first :invoice-expense-account/amount))))))))
;; ============================================================================
;; Undo Autopay (19.1)
;; ============================================================================
(deftest test-undo-autopay-resets-status
(testing "Behavior 19.1: Given a paid invoice with a scheduled payment and no linked payments, when the user undoes autopay, then the status should reset to unpaid and outstanding should equal total"
(let [{:strs [test-client-id test-vendor-id test-account-id]}
(setup-test-data [])]
(let [invoice (gql-invoices/add-invoice
{:id (admin-token)}
{:invoice {:client_id test-client-id
:vendor_id test-vendor-id
:invoice_number "UNDO-AUTO"
:date #clj-time/date-time "2022-01-01"
:total 100.00
:expense_accounts [{:amount 100.0
:location "DT"
:account_id test-account-id}]}}
nil)
invoice-id (:id invoice)]
;; Mark as paid with scheduled payment
@(dc/transact datomic/conn
[[:upsert-invoice {:db/id invoice-id
:invoice/status :invoice-status/paid
:invoice/outstanding-balance 0.0
:invoice/scheduled-payment #inst "2022-02-01"}]])
;; Undo autopay
(gql-invoices/unautopay-invoice {:id (admin-token)} {:invoice_id invoice-id} nil)
(let [updated (dc/pull (dc/db datomic/conn)
[{:invoice/status [:db/ident]} :invoice/outstanding-balance :invoice/scheduled-payment]
invoice-id)]
(is (= :invoice-status/unpaid (-> updated :invoice/status :db/ident)))
(is (= 100.0 (:invoice/outstanding-balance updated)))
(is (nil? (:invoice/scheduled-payment updated))))))))
;; ============================================================================
;; Invoice List Query Behaviors (2.6, 2.8, 2.10, 2.14)
;; ============================================================================
(deftest test-invoice-list-filtering
(testing "Behaviors 2.6, 2.8, 2.10, 2.14: Invoice list filtering"
(let [{:strs [test-client-id test-vendor-id test-account-id]}
(setup-test-data [])]
;; Create test invoices
(gql-invoices/add-invoice
{:id (admin-token)}
{:invoice {:client_id test-client-id
:vendor_id test-vendor-id
:invoice_number "FILTER-A"
:date #clj-time/date-time "2022-01-15"
:total 100.00
:expense_accounts [{:amount 100.0
:location "DT"
:account_id test-account-id}]}}
nil)
(gql-invoices/add-invoice
{:id (admin-token)}
{:invoice {:client_id test-client-id
:vendor_id test-vendor-id
:invoice_number "FILTER-B"
:date #clj-time/date-time "2022-02-15"
:total 200.00
:expense_accounts [{:amount 200.0
:location "DT"
:account_id test-account-id}]}}
nil)
;; Filter by invoice number
(let [request {:query-params {:invoice-number "FILTER-A"}
:route-params {:status nil}
:clients [{:db/id test-client-id}]}
[invoices count] (ssr-invoices/fetch-page request)]
(is (= 1 count)))
;; Filter by status
(let [request {:query-params {}
:route-params {:status :invoice-status/unpaid}
:clients [{:db/id test-client-id}]}
[invoices count] (ssr-invoices/fetch-page request)]
(is (= 2 count)))
;; Exact match by ID
(let [invoice-id (ffirst (dc/q '[:find ?i
:where [?i :invoice/invoice-number "FILTER-A"]]
(dc/db datomic/conn)))
request {:query-params {:exact-match-id invoice-id}
:route-params {:status nil}
:clients [{:db/id test-client-id}]}
[invoices count] (ssr-invoices/fetch-page request)]
(is (= 1 count))
(is (= invoice-id (:db/id (first invoices))))))))
;; ============================================================================
;; Invoice List Sorting (3.5, 3.7, 3.10)
;; ============================================================================
(deftest test-invoice-list-sorting
(testing "Behaviors 3.5, 3.7, 3.10: Invoice list sorting"
(let [{:strs [test-client-id test-vendor-id test-account-id]}
(setup-test-data [])]
(gql-invoices/add-invoice
{:id (admin-token)}
{:invoice {:client_id test-client-id
:vendor_id test-vendor-id
:invoice_number "SORT-B"
:date #clj-time/date-time "2022-02-01"
:total 200.00
:expense_accounts [{:amount 200.0
:location "DT"
:account_id test-account-id}]}}
nil)
(gql-invoices/add-invoice
{:id (admin-token)}
{:invoice {:client_id test-client-id
:vendor_id test-vendor-id
:invoice_number "SORT-A"
:date #clj-time/date-time "2022-01-01"
:total 100.00
:expense_accounts [{:amount 100.0
:location "DT"
:account_id test-account-id}]}}
nil)
;; Sort by date ascending
(let [request {:query-params {:sort [{:sort-key "date" :asc true}]}
:route-params {:status nil}
:clients [{:db/id test-client-id}]}
[invoices count] (ssr-invoices/fetch-page request)]
(is (= "SORT-A" (:invoice/invoice-number (first invoices)))))
;; Sort by invoice number
(let [request {:query-params {:sort [{:sort-key "invoice-number" :asc true}]}
:route-params {:status nil}
:clients [{:db/id test-client-id}]}
[invoices count] (ssr-invoices/fetch-page request)]
(is (= "SORT-A" (:invoice/invoice-number (first invoices)))))
;; Toggle sort direction
(let [request-asc {:query-params {:sort [{:sort-key "date" :asc true}]}
:route-params {:status nil}
:clients [{:db/id test-client-id}]}
[invoices-asc count] (ssr-invoices/fetch-page request-asc)
request-desc {:query-params {:sort [{:sort-key "date" :asc false}]}
:route-params {:status nil}
:clients [{:db/id test-client-id}]}
[invoices-desc count] (ssr-invoices/fetch-page request-desc)]
(is (not= (:invoice/invoice-number (first invoices-asc))
(:invoice/invoice-number (first invoices-desc))))))))
;; ============================================================================
;; Invoice List Pagination (4.1, 4.3)
;; ============================================================================
(deftest test-invoice-list-pagination
(testing "Behaviors 4.1, 4.3: Invoice list pagination"
(let [{:strs [test-client-id test-vendor-id test-account-id]}
(setup-test-data [])]
;; Create 30 invoices
(doseq [i (range 30)]
(gql-invoices/add-invoice
{:id (admin-token)}
{:invoice {:client_id test-client-id
:vendor_id test-vendor-id
:invoice_number (str "PAGE-" i)
:date #clj-time/date-time "2022-01-01"
:total 100.00
:expense_accounts [{:amount 100.0
:location "DT"
:account_id test-account-id}]}}
nil))
;; Default 25 per page
(let [request {:query-params {}
:route-params {:status nil}
:clients [{:db/id test-client-id}]}
[invoices total-count total-outstanding total-amount] (ssr-invoices/fetch-page request)]
(is (= 25 (count invoices)))
(is (= 30 total-count))
(is (= 3000.0 total-outstanding))
(is (= 3000.0 total-amount))))))
;; ============================================================================
;; Legacy Routes (28.1)
;; ============================================================================
(deftest test-legacy-routes
(testing "Behavior 28.1: It should redirect old SPA routes to the new SSR routes"
(let [handler (ssr-invoices/redirect-handler ::ssr-invoices/route/all-page)
response (handler {:query-params {}})]
(is (= 302 (:status response)))
(is (get-in response [:headers "Location"])))))

6
test/clj/auto_ap/integration/routes/ezcater_xls.clj
View File

@@ -34,18 +34,18 @@
:client test-client
:location "DT"
:external-id
"ezcater/charge/17592186045501-DT-ZA2-320-0"
(str "ezcater/charge/" test-client "-DT-ZA2-320-0")
:processor :ccp-processor/ezcater
:total 516.12
:tip 0.0}]
:client test-client
:tip 0.0
:tax 37.12
:external-id "ezcater/order/17592186045501-DT-ZA2-320"
:external-id (str "ezcater/order/" test-client "-DT-ZA2-320")
:total 516.12
:line-items
[#:order-line-item{:external-id
"ezcater/order/17592186045501-DT-ZA2-320-0"
(str "ezcater/order/" test-client "-DT-ZA2-320-0")
:item-name "EZCater Catering"
:category "EZCater Catering"
:discount 0.0

18
test/clj/auto_ap/integration/util.clj
View File

@@ -5,7 +5,8 @@
(defn wrap-setup
[f]
(with-redefs [auto-ap.datomic/uri "datomic:mem://test"]
(with-redefs [auto-ap.datomic/uri "datomic:mem://test"
auto-ap.solr/impl (auto-ap.solr/->InMemSolrClient (atom {}))]
(dc/create-database auto-ap.datomic/uri)
(with-redefs [auto-ap.datomic/conn (dc/connect auto-ap.datomic/uri)]
(transact-schema conn)
@@ -28,6 +29,13 @@
:user/name "TEST USER"
:user/clients [{:db/id client-id}]}))
(defn user-token-no-access []
{:user "TEST USER"
:exp (time/plus (time/now) (time/days 1))
:user/role "user"
:user/name "TEST USER"
:user/clients []})
@@ -101,8 +109,7 @@
(dissoc x :id))
(defn setup-test-data [data]
(:tempids @(dc/transact conn (into data
[(test-account :db/id "test-account-id")
(let [defaults [(test-account :db/id "test-account-id")
(test-client :db/id "test-client-id"
:client/bank-accounts [(test-bank-account :db/id "test-bank-account-id")])
(test-vendor :db/id "test-vendor-id")
@@ -110,7 +117,10 @@
:account/name "Accounts Payable"
:db/ident :account/accounts-payable
:account/numeric-code 21000
:account/account-set "default"}]))))
:account/account-set "default"}]
user-ids (set (keep :db/id data))
merged (into [] (concat data (remove #(user-ids (:db/id %)) defaults)))]
(:tempids @(dc/transact conn merged))))
(defn apply-tx [data]
(:db-after @(dc/transact conn data)))

408
test/clj/auto_ap/ssr/invoice/invoice_unit_test.clj Normal file
View File

@@ -0,0 +1,408 @@
(ns auto-ap.ssr.invoice.invoice-unit-test
(:require [clojure.test :refer [deftest testing is]]
[auto-ap.ssr.invoice.new-invoice-wizard :as sut]
[auto-ap.ssr.invoices :as invoices]
[auto-ap.ssr.invoice.glimpse :as glimpse]
[slingshot.slingshot :refer [try+]]
[clj-time.core :as time]))
(deftest assert-invoice-amounts-add-up-test
(testing "Valid when expense accounts sum equals invoice total"
(is (nil? (sut/assert-invoice-amounts-add-up
{:invoice/expense-accounts [{:invoice-expense-account/amount 50.0}
{:invoice-expense-account/amount 50.0}]
:invoice/total 100.0}))))
(testing "Valid with single expense account matching total"
(is (nil? (sut/assert-invoice-amounts-add-up
{:invoice/expense-accounts [{:invoice-expense-account/amount 100.0}]
:invoice/total 100.0}))))
(testing "Valid with floating point amounts within tolerance"
(is (nil? (sut/assert-invoice-amounts-add-up
{:invoice/expense-accounts [{:invoice-expense-account/amount 33.33}
{:invoice-expense-account/amount 33.33}
{:invoice-expense-account/amount 33.34}]
:invoice/total 100.0}))))
(testing "Throws when expense accounts sum does not equal total"
(is (thrown? clojure.lang.ExceptionInfo
(sut/assert-invoice-amounts-add-up
{:invoice/expense-accounts [{:invoice-expense-account/amount 40.0}]
:invoice/total 100.0}))))
(testing "Throws when expense accounts sum is greater than total"
(is (thrown? clojure.lang.ExceptionInfo
(sut/assert-invoice-amounts-add-up
{:invoice/expense-accounts [{:invoice-expense-account/amount 150.0}]
:invoice/total 100.0})))))
(deftest does-amount-exceed-outstanding-test
(testing "Valid when amount equals positive outstanding balance"
(is (not (invoices/does-amount-exceed-outstanding? 100.0 100.0))))
(testing "Valid when amount is less than positive outstanding balance"
(is (not (invoices/does-amount-exceed-outstanding? 50.0 100.0))))
(testing "Invalid when amount exceeds positive outstanding balance"
(is (invoices/does-amount-exceed-outstanding? 150.0 100.0)))
(testing "Invalid when amount is zero or negative for positive outstanding"
(is (invoices/does-amount-exceed-outstanding? 0.0 100.0))
(is (invoices/does-amount-exceed-outstanding? -10.0 100.0)))
(testing "Valid when amount equals negative outstanding balance"
(is (not (invoices/does-amount-exceed-outstanding? -100.0 -100.0))))
(testing "Valid when amount is greater than negative outstanding balance"
(is (not (invoices/does-amount-exceed-outstanding? -50.0 -100.0))))
(testing "Invalid when amount is less than negative outstanding balance"
(is (invoices/does-amount-exceed-outstanding? -150.0 -100.0)))
(testing "Invalid when amount is zero or positive for negative outstanding"
(is (invoices/does-amount-exceed-outstanding? 0.0 -100.0))
(is (invoices/does-amount-exceed-outstanding? 10.0 -100.0)))
(testing "Invalid when amount is non-zero for zero outstanding"
(is (invoices/does-amount-exceed-outstanding? 10.0 0.0))
(is (invoices/does-amount-exceed-outstanding? -10.0 0.0)))
(testing "Valid when amount is zero for zero outstanding"
(is (not (invoices/does-amount-exceed-outstanding? 0.0 0.0)))))
(deftest assert-percentages-add-up-test
(testing "Valid when percentages sum to 100%"
(is (nil? (invoices/assert-percentages-add-up
{:expense-accounts [{:percentage 0.5}
{:percentage 0.5}]}))))
(testing "Valid with single account at 100%"
(is (nil? (invoices/assert-percentages-add-up
{:expense-accounts [{:percentage 1.0}]}))))
(testing "Valid with floating point within tolerance"
(is (nil? (invoices/assert-percentages-add-up
{:expense-accounts [{:percentage 0.333}
{:percentage 0.333}
{:percentage 0.334}]}))))
(testing "Throws when percentages sum to less than 100%"
(is (thrown? clojure.lang.ExceptionInfo
(invoices/assert-percentages-add-up
{:expense-accounts [{:percentage 0.5}]}))))
(testing "Throws when percentages sum to more than 100%"
(is (thrown? clojure.lang.ExceptionInfo
(invoices/assert-percentages-add-up
{:expense-accounts [{:percentage 0.8}
{:percentage 0.8}]})))))
(deftest stack-rank-test
(testing "Ranks fields by confidence and returns text values"
(let [fields [{:type {:text "AMOUNT_DUE" :confidence 0.9}
:value-detection {:text "$123.45" :confidence 0.95}}
{:type {:text "AMOUNT_DUE" :confidence 0.8}
:value-detection {:text "$100.00" :confidence 0.9}}
{:type {:text "TOTAL" :confidence 0.9}
:value-detection {:text "$150.00" :confidence 0.85}}]]
(is (= ["$123.45" "$150.00" "$100.00"]
(glimpse/stack-rank #{"AMOUNT_DUE" "TOTAL"} fields)))))
(testing "Filters out fields not in valid-values set"
(let [fields [{:type {:text "AMOUNT_DUE" :confidence 0.9}
:value-detection {:text "$123.45" :confidence 0.95}}
{:type {:text "OTHER" :confidence 0.9}
:value-detection {:text "$999.00" :confidence 0.99}}]]
(is (= ["$123.45"]
(glimpse/stack-rank #{"AMOUNT_DUE"} fields)))))
(testing "Returns empty when no fields match"
(is (empty? (glimpse/stack-rank #{"TOTAL"} []))))
(testing "Filters blank values"
(let [fields [{:type {:text "TOTAL" :confidence 0.9}
:value-detection {:text "" :confidence 0.95}}
{:type {:text "TOTAL" :confidence 0.8}
:value-detection {:text " " :confidence 0.9}}]]
(is (empty? (glimpse/stack-rank #{"TOTAL"} fields))))))
(deftest deduplicate-test
(testing "Removes duplicate parsed values keeping first occurrence"
(let [data [["$123.45" 123.45]
["123.45" 123.45]
["$100.00" 100.0]
["100" 100.0]]]
(is (= [["$123.45" 123.45] ["$100.00" 100.0]]
(glimpse/deduplicate data)))))
(testing "Returns empty for empty input"
(is (empty? (glimpse/deduplicate []))))
(testing "Preserves all unique values"
(let [data [["A" 1] ["B" 2] ["C" 3]]]
(is (= [["A" 1] ["B" 2] ["C" 3]]
(glimpse/deduplicate data)))))
(testing "Handles nil parsed values (nil is not deduplicated due to set semantics)"
(let [data [["A" nil] ["B" nil] ["C" 3]]]
(is (= [["A" nil] ["B" nil] ["C" 3]]
(glimpse/deduplicate data))))))
(deftest clientize-vendor-test
(testing "Returns nil when vendor is nil"
(is (nil? (sut/clientize-vendor nil 123))))
(testing "Applies terms override for matching client"
(let [vendor {:vendor/terms 30
:vendor/terms-overrides [{:vendor-terms-override/client {:db/id 123}
:vendor-terms-override/terms 15}]
:vendor/automatically-paid-when-due []
:vendor/default-account {:db/id 1 :account/name "Food"}}]
(is (= 15 (:vendor/terms (sut/clientize-vendor vendor 123))))))
(testing "Keeps default terms when no override for client"
(let [vendor {:vendor/terms 30
:vendor/terms-overrides [{:vendor-terms-override/client {:db/id 999}
:vendor-terms-override/terms 15}]
:vendor/automatically-paid-when-due []
:vendor/default-account {:db/id 1 :account/name "Food"}}]
(is (= 30 (:vendor/terms (sut/clientize-vendor vendor 123))))))
(testing "Applies account override for matching client"
(let [vendor {:vendor/terms 30
:vendor/account-overrides [{:vendor-account-override/client {:db/id 123}
:vendor-account-override/account {:db/id 2 :account/name "Override"}}]
:vendor/automatically-paid-when-due []
:vendor/default-account {:db/id 1 :account/name "Food"}}]
(is (= "Override" (:account/name (:vendor/default-account (sut/clientize-vendor vendor 123)))))))
(testing "Uses default account when no account override for client"
(let [vendor {:vendor/terms 30
:vendor/account-overrides [{:vendor-account-override/client {:db/id 999}
:vendor-account-override/account {:db/id 2 :account/name "Override"}}]
:vendor/automatically-paid-when-due []
:vendor/default-account {:db/id 1 :account/name "Food"}}]
(is (= "Food" (:account/name (:vendor/default-account (sut/clientize-vendor vendor 123)))))))
(testing "Sets automatically-paid-when-due when client is in the list"
(let [vendor {:vendor/terms 30
:vendor/automatically-paid-when-due [{:db/id 123}]
:vendor/default-account {:db/id 1 :account/name "Food"}}]
(is (true? (:vendor/automatically-paid-when-due (sut/clientize-vendor vendor 123))))))
(testing "Clears automatically-paid-when-due when client is not in the list"
(let [vendor {:vendor/terms 30
:vendor/automatically-paid-when-due [{:db/id 999}]
:vendor/default-account {:db/id 1 :account/name "Food"}}]
(is (false? (:vendor/automatically-paid-when-due (sut/clientize-vendor vendor 123))))))
(testing "Removes override fields from result"
(let [vendor {:vendor/terms 30
:vendor/terms-overrides [{:vendor-terms-override/client {:db/id 123}
:vendor-terms-override/terms 15}]
:vendor/account-overrides [{:vendor-account-override/client {:db/id 123}
:vendor-account-override/account {:db/id 2 :account/name "Override"}}]
:vendor/automatically-paid-when-due []
:vendor/default-account {:db/id 1 :account/name "Food"}}
result (sut/clientize-vendor vendor 123)]
(is (nil? (:vendor/terms-overrides result)))
(is (nil? (:vendor/account-overrides result))))))
(deftest location-select-test
(testing "Uses account location when provided"
(let [result (sut/location-select* {:name "loc"
:account-location "DT"
:client-locations ["MH" "DE"]
:value nil})]
(is (= :select (first result)))
(is (some #(= "DT" %) (flatten result)))))
(testing "Defaults to Shared when no account location but client locations exist"
(let [result (sut/location-select* {:name "loc"
:account-location nil
:client-locations ["MH" "DE"]
:value nil})]
(is (= :select (first result)))
(is (some #(= "Shared" %) (flatten result)))
(is (some #(= "MH" %) (flatten result)))
(is (some #(= "DE" %) (flatten result)))))
(testing "Defaults to Shared when no locations provided"
(let [result (sut/location-select* {:name "loc"
:account-location nil
:client-locations nil
:value nil})]
(is (= :select (first result)))
(is (some #(= "Shared" %) (flatten result))))))
(deftest maybe-code-accounts-test
(testing "Creates single account with specified location"
(let [invoice {:invoice/total 100.0}
rules [{:percentage 1.0 :account "acc-1" :location "DT"}]
result (invoices/maybe-code-accounts invoice rules ["MH" "DE"])]
(is (= 1 (count result)))
(is (= "acc-1" (:invoice-expense-account/account (first result))))
(is (= "DT" (:invoice-expense-account/location (first result))))
(is (= 100.0 (:invoice-expense-account/amount (first result))))))
(testing "Spreads Shared location across all valid locations"
(let [invoice {:invoice/total 100.0}
rules [{:percentage 1.0 :account "acc-1" :location "Shared"}]
result (invoices/maybe-code-accounts invoice rules ["MH" "DE"])]
(is (= 2 (count result)))
(is (= #{"MH" "DE"} (set (map :invoice-expense-account/location result))))
(is (= 100.0 (reduce + 0.0 (map :invoice-expense-account/amount result))))))
(testing "Handles odd totals with correct rounding for Shared locations"
(let [invoice {:invoice/total 100.0}
rules [{:percentage 1.0 :account "acc-1" :location "Shared"}]
result (invoices/maybe-code-accounts invoice rules ["MH" "DE" "DT"])]
(is (= 3 (count result)))
(is (= 100.0 (reduce + 0.0 (map :invoice-expense-account/amount result))))
(is (every? #(<= (count (re-find #"\.\d+" (str %))) 3) (map :invoice-expense-account/amount result)))))
(testing "Handles multiple account rules"
(let [invoice {:invoice/total 100.0}
rules [{:percentage 0.5 :account "acc-1" :location "DT"}
{:percentage 0.5 :account "acc-2" :location "Shared"}]
result (invoices/maybe-code-accounts invoice rules ["MH" "DE"])]
(is (= 3 (count result)))
(is (= 100.0 (reduce + 0.0 (map :invoice-expense-account/amount result))))))
(testing "Uses absolute value for negative totals (produces positive amounts)"
(let [invoice {:invoice/total -100.0}
rules [{:percentage 1.0 :account "acc-1" :location "Shared"}]
result (invoices/maybe-code-accounts invoice rules ["MH" "DE"])]
(is (= 2 (count result)))
(is (= 100.0 (reduce + 0.0 (map :invoice-expense-account/amount result)))))))
(deftest can-undo-autopayment-test
(testing "Returns true for paid invoice with scheduled payment and no linked payments"
(with-redefs [auto-ap.graphql.utils/assert-not-locked-ssr (fn [& _] nil)]
(is (true? (invoices/can-undo-autopayment
{:invoice/status :invoice-status/paid
:invoice/scheduled-payment #inst "2024-01-01"
:invoice/payments nil
:invoice/client {:db/id 1}
:invoice/date #inst "2024-01-01"})))))
(testing "Returns false for invoice without scheduled payment (behavior 19.2)"
(with-redefs [auto-ap.graphql.utils/assert-not-locked-ssr (fn [& _] nil)]
(is (false? (invoices/can-undo-autopayment
{:invoice/status :invoice-status/paid
:invoice/scheduled-payment nil
:invoice/payments nil
:invoice/client {:db/id 1}
:invoice/date #inst "2024-01-01"})))))
(testing "Returns false for invoice with linked payments (behavior 19.3)"
(with-redefs [auto-ap.graphql.utils/assert-not-locked-ssr (fn [& _] nil)]
(is (false? (invoices/can-undo-autopayment
{:invoice/status :invoice-status/paid
:invoice/scheduled-payment #inst "2024-01-01"
:invoice/payments [{:db/id 1}]
:invoice/client {:db/id 1}
:invoice/date #inst "2024-01-01"})))))
(testing "Returns false for invoice that is not paid (behavior 19.4)"
(with-redefs [auto-ap.graphql.utils/assert-not-locked-ssr (fn [& _] nil)]
(is (false? (invoices/can-undo-autopayment
{:invoice/status :invoice-status/unpaid
:invoice/scheduled-payment #inst "2024-01-01"
:invoice/payments nil
:invoice/client {:db/id 1}
:invoice/date #inst "2024-01-01"})))))
(testing "Returns false for voided invoice"
(with-redefs [auto-ap.graphql.utils/assert-not-locked-ssr (fn [& _] nil)]
(is (false? (invoices/can-undo-autopayment
{:invoice/status :invoice-status/voided
:invoice/scheduled-payment #inst "2024-01-01"
:invoice/payments nil
:invoice/client {:db/id 1}
:invoice/date #inst "2024-01-01"}))))))
(deftest due-date-calculation-test
(testing "Calculates due date from vendor terms (behavior 8.2)"
(let [invoice-date (time/date-time 2024 1 1)
vendor-terms 30
expected-due (time/plus invoice-date (time/days vendor-terms))]
(is (= expected-due
(time/plus invoice-date (time/days vendor-terms))))))
(testing "Due date is date plus terms days"
(let [date (time/date-time 2024 6 15)
terms 15]
(is (= (time/date-time 2024 6 30)
(time/plus date (time/days terms)))))))
(deftest scheduled-payment-calculation-test
(testing "Scheduled payment equals due date when autopay is enabled (behavior 8.3)"
(let [due-date (time/date-time 2024 1 31)
vendor {:vendor/automatically-paid-when-due true}]
(is (= due-date
(when (:vendor/automatically-paid-when-due vendor)
due-date)))))
(testing "No scheduled payment when autopay is disabled"
(let [due-date (time/date-time 2024 1 31)
vendor {:vendor/automatically-paid-when-due false}]
(is (nil?
(when (:vendor/automatically-paid-when-due vendor)
due-date)))))
(testing "No scheduled payment when no due date"
(let [vendor {:vendor/automatically-paid-when-due true}]
(is (nil?
(when nil
(:vendor/automatically-paid-when-due vendor)))))))
(deftest due-date-display-test
(testing "Displays 'today' when due date is today (behavior 1.7)"
(let [today (time/now)
days 0]
(is (= 0 days))
(is (= "today"
(cond (= 0 days) "today"
(> days 0) (format "in %d days" days)
:else (format "%d days ago" (- days))))))))
(deftest can-handwrite-test
(testing "Returns true for single vendor with positive balance"
(is (true? (invoices/can-handwrite?
[{:invoice/vendor {:db/id 1}
:invoice/outstanding-balance 100.0}]))))
(testing "Returns false for multiple vendors"
(is (false? (invoices/can-handwrite?
[{:invoice/vendor {:db/id 1}
:invoice/outstanding-balance 100.0}
{:invoice/vendor {:db/id 2}
:invoice/outstanding-balance 50.0}]))))
(testing "Returns false for zero or negative total balance"
(is (false? (invoices/can-handwrite?
[{:invoice/vendor {:db/id 1}
:invoice/outstanding-balance 0.0}])))
(is (false? (invoices/can-handwrite?
[{:invoice/vendor {:db/id 1}
:invoice/outstanding-balance -50.0}])))))
(deftest credit-only-test
(testing "Returns true when all vendor totals are zero or negative"
(is (true? (invoices/credit-only?
[{:invoice/vendor {:db/id 1}
:invoice/outstanding-balance -100.0}
{:invoice/vendor {:db/id 1}
:invoice/outstanding-balance -50.0}]))))
(testing "Returns false when any vendor total is positive"
(is (false? (invoices/credit-only?
[{:invoice/vendor {:db/id 1}
:invoice/outstanding-balance -100.0}
{:invoice/vendor {:db/id 2}
:invoice/outstanding-balance 50.0}]))))
(testing "Returns true for empty invoice list"
(is (true? (invoices/credit-only? [])))))

5
test/clj/auto_ap/ssr/invoice/new_invoice_wizard_test.clj
View File

@@ -2,7 +2,6 @@
(:require [clojure.test :refer [deftest testing is]]
[auto-ap.ssr.invoice.new-invoice-wizard :as sut9]))
(deftest maybe-spread-locations-test
(testing "Shared amount correctly spread across multiple locations"
(let [invoice {:invoice/expense-accounts [{:invoice-expense-account/amount 100.0
@@ -30,8 +29,6 @@
:invoice-expense-account/location "Location 2"}]
(map #(select-keys % #{:invoice-expense-account/amount :invoice-expense-account/location}) (:invoice/expense-accounts result))))))
(testing "Shared amount correctly spread with leftovers"
(let [invoice {:invoice/expense-accounts [{:invoice-expense-account/amount 100.0
:invoice-expense-account/location "Shared"}]
@@ -84,7 +81,7 @@
{:invoice-expense-account/amount -5
:invoice-expense-account/location "Shared"}]
:invoice/total -101}
result (sut8/maybe-spread-locations invoice ["Location 1" ])]
result (sut9/maybe-spread-locations invoice ["Location 1"])]
(is (=
[{:invoice-expense-account/amount -100.0
:invoice-expense-account/location "Location 1"}