From f42d9376918f760725a7297f8d15ff4682f32d1a Mon Sep 17 00:00:00 2001
From: Bryce <bryce@brycecovertoperations.com>
Date: Tue, 26 May 2026 21:16:37 -0700
Subject: [PATCH] fix: replace broken hx-vals JS with hx-include for
 transaction nav links

The hx-vals attribute with a JavaScript IIFE was causing a SyntaxError
when navigating to the transactions page from any other page. Replaced
with hx-include="#transaction-filters" which correctly preserves
filter state across transaction sub-pages.
---
 src/clj/auto_ap/ssr/components/aside.clj | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/clj/auto_ap/ssr/components/aside.clj b/src/clj/auto_ap/ssr/components/aside.clj
index b9aa9576..badf1786 100644
--- a/src/clj/auto_ap/ssr/components/aside.clj
+++ b/src/clj/auto_ap/ssr/components/aside.clj
@@ -289,22 +289,22 @@
                  (menu-button- {:href (transaction-nav-url request ::transaction-routes/page)
                                 :active? (= ::transaction-routes/page (:matched-route request))
                                 :hx-boost "true"
-                                :hx-vals "js:(() => { const p = new URLSearchParams(window.location.search); p.delete('status'); p.delete('start'); p.delete('per-page'); return Object.fromEntries(p); })()"}
+                                :hx-include "#transaction-filters"}
                                "All")
                  (menu-button- {:href (transaction-nav-url request ::transaction-routes/unapproved-page)
                                 :active? (= ::transaction-routes/unapproved-page (:matched-route request))
                                 :hx-boost "true"
-                                :hx-vals "js:(() => { const p = new URLSearchParams(window.location.search); p.delete('status'); p.delete('start'); p.delete('per-page'); return Object.fromEntries(p); })()"}
+                                :hx-include "#transaction-filters"}
                                "Unapproved")
                  (menu-button- {:href (transaction-nav-url request ::transaction-routes/requires-feedback-page)
                                 :active? (= ::transaction-routes/requires-feedback-page (:matched-route request))
                                 :hx-boost "true"
-                                :hx-vals "js:(() => { const p = new URLSearchParams(window.location.search); p.delete('status'); p.delete('start'); p.delete('per-page'); return Object.fromEntries(p); })()"}
+                                :hx-include "#transaction-filters"}
                                "Client Review")
                  (menu-button- {:href (transaction-nav-url request ::transaction-routes/approved-page)
                                 :active? (= ::transaction-routes/approved-page (:matched-route request))
                                 :hx-boost "true"
-                                :hx-vals "js:(() => { const p = new URLSearchParams(window.location.search); p.delete('status'); p.delete('start'); p.delete('per-page'); return Object.fromEntries(p); })()"}
+                                :hx-include "#transaction-filters"}
                                "Approved")
                  (when (can? (:identity request)
                              {:subject :transaction :activity :insights})