Making terraform have no warnings

This commit is contained in:
Bryce Covert
2021-12-24 08:10:20 -08:00
parent 4da3789569
commit dfc88602a0
5 changed files with 32 additions and 24 deletions

View File

@@ -18,8 +18,8 @@ resource "aws_ecs_task_definition" "integreat_app" {
cpu = 2048
network_mode = "awsvpc"
requires_compatibilities = ["FARGATE"]
execution_role_arn = "${var.execution_role_arn}"
task_role_arn = "${var.task_role_arn}"
execution_role_arn = var.execution_role_arn
task_role_arn = var.task_role_arn
}
@@ -31,13 +31,13 @@ resource "aws_ecs_task_definition" "integreat_background_worker" {
cpu = 1024
network_mode = "awsvpc"
requires_compatibilities = ["FARGATE"]
execution_role_arn = "${var.execution_role_arn}"
task_role_arn = "${var.task_role_arn}"
execution_role_arn = var.execution_role_arn
task_role_arn = var.task_role_arn
}
resource "aws_ecs_service" "integreat_app" {
name = "integreat_app_${var.stage}"
cluster = "${var.ecs_cluster}"
cluster = var.ecs_cluster
task_definition = aws_ecs_task_definition.integreat_app.arn
desired_count = 4
health_check_grace_period_seconds = 600
@@ -66,11 +66,14 @@ resource "aws_ecs_service" "integreat_app" {
}
timeouts {}
lifecycle {
ignore_changes = [task_definition]
}
}
resource "aws_ecs_service" "integreat_background_worker" {
name = "integreat_background_worker_${var.stage}"
cluster = "${var.ecs_cluster}"
cluster = var.ecs_cluster
task_definition = aws_ecs_task_definition.integreat_background_worker.arn
desired_count = 1
deployment_controller {
@@ -93,13 +96,17 @@ resource "aws_ecs_service" "integreat_background_worker" {
}
timeouts {}
lifecycle {
ignore_changes = [task_definition]
}
}
resource "aws_lb" "integreat_app" {
name = "integreat-app-${var.stage}"
internal = false
load_balancer_type = "application"
security_groups = ["${var.http_listener_sg}"]
security_groups = [var.http_listener_sg]
subnets = var.lb_subnets
ip_address_type = "ipv4"
enable_deletion_protection = true
@@ -205,7 +212,7 @@ resource "aws_lb_listener_rule" "static" {
}
resource "aws_s3_bucket" "static" {
bucket = "${var.domain}"
bucket = var.domain
request_payer = "BucketOwner"
tags = {}
cors_rule {
@@ -219,7 +226,7 @@ resource "aws_s3_bucket" "static" {
"GET",
]
allowed_origins = [
"${var.base_url}",
var.base_url,
]
expose_headers = []
max_age_seconds = 0
@@ -254,7 +261,7 @@ POLICY
}
resource "aws_acm_certificate" "cert" {
domain_name = "${var.domain}"
domain_name = var.domain
validation_method = "DNS"
}