notid/integreat
1
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

docs(skill): record faked-cursor de-fake learning + Phase 2 scorecard progress

Browse Source 
- gotchas.md: de-faking a cursor is not a drop-in -- with-field-default mutates the
  cursor (transact!) as a render side effect and broke the simple-mode swap; the de-fake
  belongs with the render-fn rewrite, verified against the swap spec.
- scorecard.md: append the Phase 2 (in-progress) Transaction Edit row -- no-cursor 1->0,
  LOC 1608->1555, parity held (swap 6/6 + Shared Location). Faked roots / snapshot /
  Selmer / route-collapse remain as the wholesale-rendering continuation of Phase 2.
This commit is contained in:
Bryce
2026-06-03 06:20:04 -07:00
parent 32056bf396
commit a7ccdb12f3
2 changed files with 23 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
.claude/skills/ssr-form-migration/reference/scorecard.md
View File

@@ -39,8 +39,14 @@ Each migration appends one row (after-numbers), referencing the before in the di
| Phase | Modal | LOC | Routes | no-cursor twins | faked roots | snapshot merges | OOB | mixed hx- | cookbook reused / added |
|-------|-------|-----|--------|-----------------|-------------|-----------------|-----|-----------|-------------------------|
| 1 (baseline) | Transaction Edit `transaction/edit.clj` | 1608 | ~12 | 1 | 2 | ~75 | 0 | 8 | — / seeded 7 entries |
| 2 (in progress) | Transaction Edit `transaction/edit.clj` | 1555 | ~12 | **0** | 2 | ~75 | 0 | 8 | — / 0 |
> Phase 1 is distillation only — no app code changed. The Transaction Edit row is the
> **before** baseline that Phase 2 must beat (target: routes → ~3, no-cursor → 0, faked
> roots → 0, snapshot merges → 0, LOC ↓, mixed hx- → 0). The `0` OOB is already achieved
> by the merged reference and must not regress.
> **Phase 2 progress (partial).** Achieved with parity held (swap spec 6/6 + Shared
> Location green): deleted the dead `*-no-cursor*` twin (no-cursor 1→0, −53 LOC) and fixed
> a real production bug (`:mode` leaking into the upsert → 500 on every advanced manual
> save). **Still open** for this modal — and intentionally *not* forced under parity risk:
> faked cursor roots (2 — de-faking needs the render-fn rewrite, see `gotchas.md`), the
> snapshot round-trip (~75 — removed by the wizard→plain-form reclassification), Selmer
> conversion of the render fns, and route collapse (~12 → ~3). These are the bulk of the
> modal migration and require restructuring the modal's rendering wholesale rather than
> isolated edits; track as the continuation of Phase 2.