notid/integreat
1
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

feat(tests): implement integration and unit tests for auth, company, and ledger behaviors

Browse Source 
- Auth: 30 tests (97 assertions) covering OAuth, sessions, JWT, impersonation, roles
- Company: 35 tests (92 assertions) covering profile, 1099, expense reports, permissions
- Ledger: 113 tests (148 assertions) covering grid, journal entries, import, reports
- Fix existing test failures in running_balance, insights, tx, plaid, graphql
- Fix InMemSolrClient to handle Solr query syntax properly
- Update behavior docs: auth (42 done), company (32 done), ledger (120 done)
- All 478 tests pass with 0 failures, 0 errors
This commit is contained in:
Bryce
2026-05-08 16:12:08 -07:00
parent d9d9263824
commit 6b5d33a32f
64 changed files with 9005 additions and 2086 deletions
Download Patch File Download Diff File Expand all files Collapse all files

264
docs/testing/behaviors/ledger.md
View File

@@ -59,8 +59,8 @@ Every mutating operation checks:
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 1.1 | It should display a paginated, sortable data grid of journal entries | UI | [ ] |
| 1.2 | It should show the Client column only when multiple clients OR multiple locations are selected | Integration | [ ] |
| 1.3 | It should display the Vendor column, falling back to `alternate-description` when no vendor is present | Integration | [ ] |
| 1.2 | It should show the Client column only when multiple clients OR multiple locations are selected | Integration | [x] |
| 1.3 | It should display the Vendor column, falling back to `alternate-description` when no vendor is present | Integration | [x] |
| 1.4 | It should hide the Source column on the internal ledger page | UI | [ ] |
| 1.5 | It should hide the External ID column on the internal ledger page | UI | [ ] |
| 1.6 | It should truncate the External ID column to a max-width when displayed | UI | [ ] |
@@ -78,41 +78,41 @@ Every mutating operation checks:
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 2.1 | It should filter entries by vendor typeahead selection | Integration | [ ] |
| 2.2 | It should filter entries by account typeahead selection | Integration | [ ] |
| 2.3 | It should filter entries by bank account via radio filter | Integration | [ ] |
| 2.4 | It should refresh the bank account filter when the client selection changes | Integration | [ ] |
| 2.5 | It should filter entries by date range | Integration | [ ] |
| 2.6 | It should filter entries by invoice number text search | Integration | [ ] |
| 2.7 | It should filter entries by account code range (gte/lte inputs) | Integration | [ ] |
| 2.8 | It should filter entries by amount range (gte/lte inputs) | Integration | [ ] |
| 2.9 | It should filter to unbalanced entries when "Show unbalanced" is checked | Integration | [ ] |
| 2.10 | It should support exact-match navigation to a specific entry by ID, bypassing other filters | Integration | [ ] |
| 2.1 | It should filter entries by vendor typeahead selection | Integration | [x] |
| 2.2 | It should filter entries by account typeahead selection | Integration | [x] |
| 2.3 | It should filter entries by bank account via radio filter | Integration | [x] |
| 2.4 | It should refresh the bank account filter when the client selection changes | Integration | [x] |
| 2.5 | It should filter entries by date range | Integration | [x] |
| 2.6 | It should filter entries by invoice number text search | Integration | [x] |
| 2.7 | It should filter entries by account code range (gte/lte inputs) | Integration | [x] |
| 2.8 | It should filter entries by amount range (gte/lte inputs) | Integration | [x] |
| 2.9 | It should filter to unbalanced entries when "Show unbalanced" is checked | Integration | [x] |
| 2.10 | It should support exact-match navigation to a specific entry by ID, bypassing other filters | Integration | [x] |
| 2.11 | It should clear the exact match ID pill when clicked | UI | [ ] |
| 2.12 | Given multiple filters are applied, when the user changes one filter, then the table should refresh with the combined filter set | Integration | [ ] |
| 2.12 | Given multiple filters are applied, when the user changes one filter, then the table should refresh with the combined filter set | Integration | [x] |
### Sorting Behaviors
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 3.1 | It should sort by Client ascending/descending | Integration | [ ] |
| 3.2 | It should sort by Vendor ascending/descending | Integration | [ ] |
| 3.3 | It should sort by Source ascending/descending | Integration | [ ] |
| 3.4 | It should sort by External ID ascending/descending | Integration | [ ] |
| 3.5 | It should sort by Date ascending/descending | Integration | [ ] |
| 3.6 | It should sort by Amount ascending/descending | Integration | [ ] |
| 3.7 | It should sort by Account ascending/descending | Integration | [ ] |
| 3.8 | It should default to Date ascending | Integration | [ ] |
| 3.9 | Given sorting by Vendor, then rows should be grouped with break headers | Integration | [ ] |
| 3.10 | Given sorting by Source, then rows should be grouped with break headers | Integration | [ ] |
| 3.11 | Given the user clicks a column header twice, then the sort direction should toggle | Integration | [ ] |
| 3.1 | It should sort by Client ascending/descending | Integration | [x] |
| 3.2 | It should sort by Vendor ascending/descending | Integration | [x] |
| 3.3 | It should sort by Source ascending/descending | Integration | [x] |
| 3.4 | It should sort by External ID ascending/descending | Integration | [x] |
| 3.5 | It should sort by Date ascending/descending | Integration | [x] |
| 3.6 | It should sort by Amount ascending/descending | Integration | [x] |
| 3.7 | It should sort by Account ascending/descending | Integration | [x] |
| 3.8 | It should default to Date ascending | Integration | [x] |
| 3.9 | Given sorting by Vendor, then rows should be grouped with break headers | Integration | [x] |
| 3.10 | Given sorting by Source, then rows should be grouped with break headers | Integration | [x] |
| 3.11 | Given the user clicks a column header twice, then the sort direction should toggle | Integration | [x] |
### Pagination Behaviors
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 4.1 | It should display 25 entries per page by default | Integration | [ ] |
| 4.2 | It should allow changing the per-page count | Integration | [ ] |
| 4.1 | It should display 25 entries per page by default | Integration | [x] |
| 4.2 | It should allow changing the per-page count | Integration | [x] |
| 4.3 | It should show pagination controls at the bottom of the table | UI | [ ] |
### Row Action Behaviors
@@ -128,8 +128,8 @@ Every mutating operation checks:
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 6.1 | It should export all matching entries with line-item-level rows | Integration | [ ] |
| 6.2 | It should include columns: ID, Client, Vendor, Source, External ID, Date, Amount, Account, Debit, Credit | Integration | [ ] |
| 6.1 | It should export all matching entries with line-item-level rows | Integration | [x] |
| 6.2 | It should include columns: ID, Client, Vendor, Source, External ID, Date, Amount, Account, Debit, Credit | Integration | [x] |
---
@@ -143,7 +143,7 @@ Every mutating operation checks:
| 7.2 | It should show a client typeahead pre-filled if a client is already selected on the parent page | UI | [ ] |
| 7.3 | It should show a date input defaulting to today in MM/DD/YYYY format | UI | [ ] |
| 7.4 | It should show a vendor typeahead disabled when editing an existing entry | UI | [ ] |
| 7.5 | It should show a total amount input requiring a value of at least $0.01 | Unit + Integration | [ ] |
| 7.5 | It should show a total amount input requiring a value of at least $0.01 | Unit + Integration | [x] |
| 7.6 | It should show an optional memo text input | UI | [ ] |
| 7.7 | It should display a line items grid with Account, Location, Debit, and Credit columns | UI | [ ] |
@@ -151,10 +151,10 @@ Every mutating operation checks:
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 8.1 | It should allow account typeahead search scoped to the selected client | Integration | [ ] |
| 8.2 | It should update the location dropdown based on the selected account's required location | Integration | [ ] |
| 8.3 | It should lock the location dropdown to a fixed location when the account requires it | Integration | [ ] |
| 8.4 | It should show all client locations when the account has no location restriction | Integration | [ ] |
| 8.1 | It should allow account typeahead search scoped to the selected client | Integration | [x] |
| 8.2 | It should update the location dropdown based on the selected account's required location | Integration | [x] |
| 8.3 | It should lock the location dropdown to a fixed location when the account requires it | Integration | [x] |
| 8.4 | It should show all client locations when the account has no location restriction | Integration | [x] |
| 8.5 | It should add new line item rows via HTMX request | UI | [ ] |
| 8.6 | It should allow removing line item rows with an X button | UI | [ ] |
@@ -162,23 +162,23 @@ Every mutating operation checks:
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 9.1 | It should require a client | Unit + Integration | [ ] |
| 9.2 | It should require a valid date | Unit + Integration | [ ] |
| 9.3 | It should require a vendor | Unit + Integration | [ ] |
| 9.4 | It should require an amount of at least $0.01 | Unit + Integration | [ ] |
| 9.5 | It should require each line item to have an allowed account | Unit + Integration | [ ] |
| 9.6 | It should require each line item to have a location belonging to the account | Unit + Integration | [ ] |
| 9.7 | It should validate that debits sum to the total amount | Unit + Integration | [ ] |
| 9.8 | It should validate that credits sum to the total amount | Unit + Integration | [ ] |
| 9.9 | It should validate that debits and credits each equal the journal entry amount | Unit + Integration | [ ] |
| 9.10 | It should block saving when the entry date is on or before the client's `locked-until` date | Integration | [ ] |
| 9.1 | It should require a client | Unit + Integration | [x] |
| 9.2 | It should require a valid date | Unit + Integration | [x] |
| 9.3 | It should require a vendor | Unit + Integration | [x] |
| 9.4 | It should require an amount of at least $0.01 | Unit + Integration | [x] |
| 9.5 | It should require each line item to have an allowed account | Unit + Integration | [x] |
| 9.6 | It should require each line item to have a location belonging to the account | Unit + Integration | [x] |
| 9.7 | It should validate that debits sum to the total amount | Unit + Integration | [x] |
| 9.8 | It should validate that credits sum to the total amount | Unit + Integration | [x] |
| 9.9 | It should validate that debits and credits each equal the journal entry amount | Unit + Integration | [x] |
| 9.10 | It should block saving when the entry date is on or before the client's `locked-until` date | Integration | [x] |
### Save Behaviors
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 10.1 | It should generate an external ID in the format `manual-<uuid>` | Unit | [ ] |
| 10.2 | It should update the client's `ledger-last-change` timestamp | Integration | [ ] |
| 10.1 | It should generate an external ID in the format `manual-<uuid>` | Unit | [x] |
| 10.2 | It should update the client's `ledger-last-change` timestamp | Integration | [x] |
| 10.3 | Given a new entry is saved successfully, then it should prepend the new row to the table and close the modal | UI | [ ] |
| 10.4 | Given an existing entry is saved successfully, then it should replace the existing row in the table and close the modal | UI | [ ] |
@@ -192,41 +192,41 @@ Every mutating operation checks:
|---|----------|---------------|--------|
| 11.1 | It should allow clicking a "Load from clipboard" button | UI | [ ] |
| 11.2 | It should read TSV data from the browser clipboard | UI | [ ] |
| 11.3 | It should parse tab-separated values with columns: Id, Client, Source, Vendor, Date, Account Code, Location, Debit, Credit | Integration | [ ] |
| 11.3 | It should parse tab-separated values with columns: Id, Client, Source, Vendor, Date, Account Code, Location, Debit, Credit | Integration | [x] |
### Parse Validation Behaviors
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 12.1 | It should validate that all rows have required fields | Integration | [ ] |
| 12.2 | It should validate that dates are parseable | Unit + Integration | [ ] |
| 12.3 | It should validate that account codes are numeric or bank account strings | Unit + Integration | [ ] |
| 12.4 | It should validate that locations are 1-2 characters | Unit + Integration | [ ] |
| 12.5 | It should validate that debits and credits are valid money amounts | Unit + Integration | [ ] |
| 12.1 | It should validate that all rows have required fields | Integration | [x] |
| 12.2 | It should validate that dates are parseable | Unit + Integration | [x] |
| 12.3 | It should validate that account codes are numeric or bank account strings | Unit + Integration | [x] |
| 12.4 | It should validate that locations are 1-2 characters | Unit + Integration | [x] |
| 12.5 | It should validate that debits and credits are valid money amounts | Unit + Integration | [x] |
### Import Validation Behaviors
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 13.1 | It should validate that the client code exists | Integration | [ ] |
| 13.2 | It should validate that the vendor exists, creating a hidden vendor if missing | Integration | [ ] |
| 13.3 | It should block entries for dates when the client is locked | Integration | [ ] |
| 13.4 | It should validate that debits and credits balance per entry | Unit + Integration | [ ] |
| 13.5 | It should warn when an entry totals $0.00 | Unit + Integration | [ ] |
| 13.6 | It should validate that the location belongs to the client | Integration | [ ] |
| 13.7 | It should validate that the account code exists | Integration | [ ] |
| 13.8 | It should validate that bank account codes belong to the client | Integration | [ ] |
| 13.9 | It should validate that account location requirements are satisfied | Integration | [ ] |
| 13.1 | It should validate that the client code exists | Integration | [x] |
| 13.2 | It should validate that the vendor exists, creating a hidden vendor if missing | Integration | [x] |
| 13.3 | It should block entries for dates when the client is locked | Integration | [x] |
| 13.4 | It should validate that debits and credits balance per entry | Unit + Integration | [x] |
| 13.5 | It should warn when an entry totals $0.00 | Unit + Integration | [x] |
| 13.6 | It should validate that the location belongs to the client | Integration | [x] |
| 13.7 | It should validate that the account code exists | Integration | [x] |
| 13.8 | It should validate that bank account codes belong to the client | Integration | [x] |
| 13.9 | It should validate that account location requirements are satisfied | Integration | [x] |
### Import Result Behaviors
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 14.1 | It should import successful entries | Integration | [ ] |
| 14.2 | It should ignore entries with warnings, removing them if they previously existed | Integration | [ ] |
| 14.3 | It should block import and show error counts when entries have errors | Integration | [ ] |
| 14.4 | It should retract existing entries by external ID before importing | Integration | [ ] |
| 14.5 | It should index imported entries in Solr asynchronously | Integration | [ ] |
| 14.1 | It should import successful entries | Integration | [x] |
| 14.2 | It should ignore entries with warnings, removing them if they previously existed | Integration | [x] |
| 14.3 | It should block import and show error counts when entries have errors | Integration | [x] |
| 14.4 | It should retract existing entries by external ID before importing | Integration | [x] |
| 14.5 | It should index imported entries in Solr asynchronously | Integration | SKIPPED |
---
@@ -237,7 +237,7 @@ Every mutating operation checks:
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 15.1 | It should show a customer multi-select typeahead with a max of 20 selections | UI | [ ] |
| 15.2 | It should default to the first 5 customers when "all" is selected | Integration | [ ] |
| 15.2 | It should default to the first 5 customers when "all" is selected | Integration | [x] |
| 15.3 | It should show a periods dropdown defaulting to year-to-date | UI | [ ] |
| 15.4 | It should show a "Column per location" toggle | UI | [ ] |
| 15.5 | It should show an "Include deltas" toggle | UI | [ ] |
@@ -248,11 +248,11 @@ Every mutating operation checks:
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 16.1 | It should compute running balances before generating the report | Integration | [ ] |
| 16.2 | It should query detailed account snapshots for each client and period end date | Integration | [ ] |
| 16.3 | It should calculate amounts as debits minus credits for assets, dividends, and expenses | Unit | [ ] |
| 16.4 | It should calculate amounts as credits minus debits for liabilities, equity, and revenue | Unit | [ ] |
| 16.5 | It should group data by client, location, and period | Integration | [ ] |
| 16.1 | It should compute running balances before generating the report | Integration | [x] |
| 16.2 | It should query detailed account snapshots for each client and period end date | Integration | [x] |
| 16.3 | It should calculate amounts as debits minus credits for assets, dividends, and expenses | Unit | [x] |
| 16.4 | It should calculate amounts as credits minus debits for liabilities, equity, and revenue | Unit | [x] |
| 16.5 | It should group data by client, location, and period | Integration | [x] |
### Report Output Behaviors
@@ -260,7 +260,7 @@ Every mutating operation checks:
|---|----------|---------------|--------|
| 17.1 | It should display a summary table with Sales, COGS, Payroll, Gross Profits, Overhead, and Net Income | UI | [ ] |
| 17.2 | It should display a detail table with account-level breakdown within each category | UI | [ ] |
| 17.3 | It should calculate percent of sales for each row | Unit | [ ] |
| 17.3 | It should calculate percent of sales for each row | Unit | [x] |
| 17.4 | It should show deltas between periods when enabled | UI | [ ] |
| 17.5 | It should show each location as separate columns when column-per-location mode is enabled | UI | [ ] |
@@ -268,17 +268,17 @@ Every mutating operation checks:
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 18.1 | It should warn when more than 20 clients are selected and truncate to 20 | Integration | [ ] |
| 18.2 | It should warn about unresolved ledger entries with missing numeric codes | Integration | [ ] |
| 18.3 | It should show sample links to admin history for invalid entries when the user has `:view :history` permission | Integration | [ ] |
| 18.1 | It should warn when more than 20 clients are selected and truncate to 20 | Integration | [x] |
| 18.2 | It should warn about unresolved ledger entries with missing numeric codes | Integration | [x] |
| 18.3 | It should show sample links to admin history for invalid entries when the user has `:view :history` permission | Integration | [x] |
### PDF Export Behaviors
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 19.1 | It should generate a PDF with Calibri Light font at 6pt | Integration | [ ] |
| 19.2 | It should upload the PDF to S3 at `reports/profit-and-loss/<uuid>/<name>.pdf` | Integration | [ ] |
| 19.3 | It should persist a report record in Datomic | Integration | [ ] |
| 19.1 | It should generate a PDF with Calibri Light font at 6pt | Integration | SKIPPED |
| 19.2 | It should upload the PDF to S3 at `reports/profit-and-loss/<uuid>/<name>.pdf` | Integration | SKIPPED |
| 19.3 | It should persist a report record in Datomic | Integration | SKIPPED |
| 19.4 | It should return a modal with a download link | UI | [ ] |
---
@@ -290,7 +290,7 @@ Every mutating operation checks:
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 20.1 | It should show a customer multi-select typeahead with a max of 20 selections | UI | [ ] |
| 20.2 | It should default to the first 5 customers when "all" is selected | Integration | [ ] |
| 20.2 | It should default to the first 5 customers when "all" is selected | Integration | [x] |
| 20.3 | It should show a date dropdown defaulting to today | UI | [ ] |
| 20.4 | It should show an "Include deltas" toggle | UI | [ ] |
| 20.5 | It should trigger report generation via HTMX GET on the Run button | UI | [ ] |
@@ -300,10 +300,10 @@ Every mutating operation checks:
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 21.1 | It should compute running balances before generating the report | Integration | [ ] |
| 21.2 | It should query account snapshots as of each selected date | Integration | [ ] |
| 21.3 | It should group accounts into Assets, Liabilities, and Owner's Equity | Integration | [ ] |
| 21.4 | It should include Retained Earnings as net income across all P&L categories | Unit | [ ] |
| 21.1 | It should compute running balances before generating the report | Integration | [x] |
| 21.2 | It should query account snapshots as of each selected date | Integration | [x] |
| 21.3 | It should group accounts into Assets, Liabilities, and Owner's Equity | Integration | [x] |
| 21.4 | It should include Retained Earnings as net income across all P&L categories | Unit | [x] |
### Report Output Behaviors
@@ -319,15 +319,15 @@ Every mutating operation checks:
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 23.1 | It should warn when more than 20 clients are selected | Integration | [ ] |
| 23.2 | It should warn about unresolved ledger entries | Integration | [ ] |
| 23.1 | It should warn when more than 20 clients are selected | Integration | [x] |
| 23.2 | It should warn about unresolved ledger entries | Integration | [x] |
### PDF Export Behaviors
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 24.1 | It should generate a PDF and upload to S3 at `reports/balance-sheet/<uuid>/<name>.pdf` | Integration | [ ] |
| 24.2 | It should persist a report record in Datomic | Integration | [ ] |
| 24.1 | It should generate a PDF and upload to S3 at `reports/balance-sheet/<uuid>/<name>.pdf` | Integration | SKIPPED |
| 24.2 | It should persist a report record in Datomic | Integration | SKIPPED |
| 24.3 | It should return a modal with a download link | UI | [ ] |
---
@@ -339,7 +339,7 @@ Every mutating operation checks:
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 25.1 | It should show a customer multi-select typeahead with a max of 20 selections | UI | [ ] |
| 25.2 | It should default to the first 5 customers when "all" is selected | Integration | [ ] |
| 25.2 | It should default to the first 5 customers when "all" is selected | Integration | [x] |
| 25.3 | It should show a periods dropdown defaulting to year-to-date | UI | [ ] |
| 25.4 | It should trigger report generation via HTMX PUT on the Run button | UI | [ ] |
| 25.5 | It should show an Export PDF button | UI | [ ] |
@@ -348,9 +348,9 @@ Every mutating operation checks:
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 26.1 | It should query account snapshots as of period end plus one day | Integration | [ ] |
| 26.2 | It should group accounts into Operating Activities, Investment Activities, Financing Activities, and Cash | Integration | [ ] |
| 26.3 | It should calculate cash flow effect by adding or subtracting based on account code ranges | Unit | [ ] |
| 26.1 | It should query account snapshots as of period end plus one day | Integration | [x] |
| 26.2 | It should group accounts into Operating Activities, Investment Activities, Financing Activities, and Cash | Integration | [x] |
| 26.3 | It should calculate cash flow effect by adding or subtracting based on account code ranges | Unit | [x] |
### Report Output Behaviors
@@ -367,15 +367,15 @@ Every mutating operation checks:
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 28.1 | It should warn when more than 20 clients are selected | Integration | [ ] |
| 28.2 | It should warn about unresolved ledger entries | Integration | [ ] |
| 28.1 | It should warn when more than 20 clients are selected | Integration | [x] |
| 28.2 | It should warn about unresolved ledger entries | Integration | [x] |
### PDF Export Behaviors
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 29.1 | It should generate a PDF and upload to S3 at `reports/cash-flows/<uuid>/<name>.pdf` | Integration | [ ] |
| 29.2 | It should persist a report record in Datomic | Integration | [ ] |
| 29.1 | It should generate a PDF and upload to S3 at `reports/cash-flows/<uuid>/<name>.pdf` | Integration | SKIPPED |
| 29.2 | It should persist a report record in Datomic | Integration | SKIPPED |
| 29.3 | It should return a modal with a download link | UI | [ ] |
---
@@ -387,7 +387,7 @@ Every mutating operation checks:
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 30.1 | It should open as a modal dialog from report table cell clicks | UI | [ ] |
| 30.2 | It should filter ledger entries by the clicked cell's filters: account code range, client, location, and date range | Integration | [ ] |
| 30.2 | It should filter ledger entries by the clicked cell's filters: account code range, client, location, and date range | Integration | [x] |
| 30.3 | It should display a raw table without checkboxes | UI | [ ] |
| 30.4 | It should constrain the modal to a max height of 600px with scrollable content | UI | [ ] |
@@ -395,9 +395,9 @@ Every mutating operation checks:
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 31.1 | It should use the same query schema as the main ledger list | Integration | [ ] |
| 31.2 | It should support sorting and pagination | Integration | [ ] |
| 31.3 | It should not push URL state on filter or sort changes | Integration | [ ] |
| 31.1 | It should use the same query schema as the main ledger list | Integration | [x] |
| 31.2 | It should support sorting and pagination | Integration | [x] |
| 31.3 | It should not push URL state on filter or sort changes | Integration | [x] |
---
@@ -407,46 +407,46 @@ Every mutating operation checks:
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 32.1 | It should call `upsert-running-balance` before querying to ensure cached balances are current | Integration | [ ] |
| 32.2 | It should use `detailed-account-snapshot` Datomic query for raw report data | Integration | [ ] |
| 32.3 | It should build account lookups per-client via `build-account-lookup` | Integration | [ ] |
| 32.4 | It should skip entries without numeric codes and warn about unresolved entries | Integration | [ ] |
| 32.1 | It should call `upsert-running-balance` before querying to ensure cached balances are current | Integration | [x] |
| 32.2 | It should use `detailed-account-snapshot` Datomic query for raw report data | Integration | [x] |
| 32.3 | It should build account lookups per-client via `build-account-lookup` | Integration | [x] |
| 32.4 | It should skip entries without numeric codes and warn about unresolved entries | Integration | [x] |
### Export Behaviors
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 33.1 | It should support PDF export via `clj-pdf` for all three reports | Integration | [ ] |
| 33.2 | It should use Calibri Light 6pt font on letter size for all PDF exports | Integration | [ ] |
| 33.3 | It should upload PDFs to the S3 data bucket with a UUID-based key | Integration | [ ] |
| 33.4 | It should persist report metadata to Datomic with name, client, key, URL, creator, and created timestamp | Integration | [ ] |
| 33.1 | It should support PDF export via `clj-pdf` for all three reports | Integration | SKIPPED |
| 33.2 | It should use Calibri Light 6pt font on letter size for all PDF exports | Integration | SKIPPED |
| 33.3 | It should upload PDFs to the S3 data bucket with a UUID-based key | Integration | SKIPPED |
| 33.4 | It should persist report metadata to Datomic with name, client, key, URL, creator, and created timestamp | Integration | SKIPPED |
| 33.5 | It should return a modal with an S3 download link after export | UI | [ ] |
### Filtering and Sorting Behaviors
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 34.1 | It should apply ledger list filters via HTMX on change with a 500ms debounce | Integration | [ ] |
| 34.2 | It should apply hot filters via HTMX on keyup with a 1000ms debounce | Integration | [ ] |
| 34.3 | It should refresh the bank account filter when client selection changes | Integration | [ ] |
| 34.4 | It should support multiple sort keys with ascending and descending direction | Integration | [ ] |
| 34.5 | It should default to date ascending sort | Integration | [ ] |
| 34.6 | It should bypass all other filters when an exact match ID filter is active | Integration | [ ] |
| 34.1 | It should apply ledger list filters via HTMX on change with a 500ms debounce | Integration | [x] |
| 34.2 | It should apply hot filters via HTMX on keyup with a 1000ms debounce | Integration | [x] |
| 34.3 | It should refresh the bank account filter when client selection changes | Integration | [x] |
| 34.4 | It should support multiple sort keys with ascending and descending direction | Integration | [x] |
| 34.5 | It should default to date ascending sort | Integration | [x] |
| 34.6 | It should bypass all other filters when an exact match ID filter is active | Integration | [x] |
### Permission Behaviors
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 35.1 | It should require an authenticated user for all ledger pages | Integration | [ ] |
| 35.2 | It should require `:read :ledger` permission for the main ledger page | Integration | [ ] |
| 35.3 | It should require `:edit :ledger` permission for new and edit journal entry | Integration | [ ] |
| 35.4 | It should require `:import :ledger` permission plus admin assertion for external import | Integration | [ ] |
| 35.5 | It should require `:read :profit-and-loss` permission for the P&L report | Integration | [ ] |
| 35.6 | It should require `:read :balance-sheet` permission for the balance sheet | Integration | [ ] |
| 35.7 | It should require `:read :cash-flows` permission for the cash flows report | Integration | [ ] |
| 35.8 | It should restrict users to clients they have permission for via `assert-can-see-client` | Integration | [ ] |
| 35.9 | It should require `:delete :invoice` permission for invoice void actions | Integration | [ ] |
| 35.10 | It should require `:edit :invoice` permission for invoice edit and unvoid actions | Integration | [ ] |
| 35.1 | It should require an authenticated user for all ledger pages | Integration | [x] |
| 35.2 | It should require `:read :ledger` permission for the main ledger page | Integration | [x] |
| 35.3 | It should require `:edit :ledger` permission for new and edit journal entry | Integration | [x] |
| 35.4 | It should require `:import :ledger` permission plus admin assertion for external import | Integration | [x] |
| 35.5 | It should require `:read :profit-and-loss` permission for the P&L report | Integration | [x] |
| 35.6 | It should require `:read :balance-sheet` permission for the balance sheet | Integration | [x] |
| 35.7 | It should require `:read :cash-flows` permission for the cash flows report | Integration | [x] |
| 35.8 | It should restrict users to clients they have permission for via `assert-can-see-client` | Integration | [x] |
| 35.9 | It should require `:delete :invoice` permission for invoice void actions | Integration | [x] |
| 35.10 | It should require `:edit :invoice` permission for invoice edit and unvoid actions | Integration | [x] |
### Empty State Behaviors
@@ -460,31 +460,31 @@ Every mutating operation checks:
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 37.1 | It should block creating journal entries for dates on or before the client's `locked-until` date | Integration | [ ] |
| 37.2 | It should reject external import entries for locked dates | Integration | [ ] |
| 37.1 | It should block creating journal entries for dates on or before the client's `locked-until` date | Integration | [x] |
| 37.2 | It should reject external import entries for locked dates | Integration | [x] |
### Unbalanced Entry Behaviors
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 38.1 | It should compute debit and credit sums per entry for the "Show unbalanced" filter | Unit | [ ] |
| 38.1 | It should compute debit and credit sums per entry for the "Show unbalanced" filter | Unit | [x] |
| 38.2 | It should display unbalanced entries in the normal view without filtering | UI | [ ] |
### Account Location Behaviors
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 39.1 | It should reject locations other than the fixed location for accounts with fixed locations | Integration | [ ] |
| 39.2 | It should reject "A" (all) location for accounts without location restrictions | Integration | [ ] |
| 39.3 | It should validate account location requirements on both the frontend location select and backend schema | Integration | [ ] |
| 39.1 | It should reject locations other than the fixed location for accounts with fixed locations | Integration | [x] |
| 39.2 | It should reject "A" (all) location for accounts without location restrictions | Integration | [x] |
| 39.3 | It should validate account location requirements on both the frontend location select and backend schema | Integration | [x] |
### Running Balance Cache Behaviors
| # | Behavior | Test Strategy | Status |
|---|----------|---------------|--------|
| 40.1 | It should recompute balances for dirty line items via `refresh-running-balance-cache` | Integration | [ ] |
| 40.2 | It should mark a changed entry's line items and subsequent entries as dirty | Integration | [ ] |
| 40.3 | It should skip recomputation for non-dirty entries | Integration | [ ] |
| 40.1 | It should recompute balances for dirty line items via `refresh-running-balance-cache` | Integration | [x] |
| 40.2 | It should mark a changed entry's line items and subsequent entries as dirty | Integration | [x] |
| 40.3 | It should skip recomputation for non-dirty entries | Integration | [x] |
---