Merge branch 'staging' of gitea.story-basking.ts.net:notid/integreat into staging

2026-08-16 08:41:06 -07:00
parent 6e7f66a78f 58f6714399
commit 69eae3b7dc
2 changed files with 75 additions and 1 deletions
--- a/test/clj/auto_ap/ssr/transaction/common_test.clj
+++ b/test/clj/auto_ap/ssr/transaction/common_test.clj
@@ -0,0 +1,68 @@
+(ns auto-ap.ssr.transaction.common-test
+  (:require
+   [auto-ap.datomic :refer [conn]]
+   [auto-ap.integration.util :refer [setup-test-data test-bank-account test-client
+                                     test-transaction wrap-setup]]
+   [auto-ap.ssr.transaction.common :as sut]
+   [clojure.test :refer [deftest is testing use-fixtures]]
+   [datomic.api :as dc]))
+
+(use-fixtures :each wrap-setup)
+
+(defn- fetch
+  "Runs the transactions page query the way the page does, over a range wide
+   enough to cover the fixture data."
+  [client-id & {:keys [route-params query-params]}]
+  (sut/fetch-ids (dc/db conn)
+                 {:clients      [client-id]
+                  :route-params (or route-params {})
+                  :query-params (merge {:start-date "2021-01-01"
+                                        :end-date   "2023-12-31"}
+                                       query-params)}))
+
+(deftest fetch-ids-suppressed-test
+  (let [{:strs [suppressed-client kept-tx suppressed-tx]}
+        (setup-test-data
+         [(test-bank-account :db/id "suppressed-bank")
+          (test-client :db/id "suppressed-client"
+                       :client/bank-accounts ["suppressed-bank"])
+          (test-transaction :db/id "kept-tx"
+                            :transaction/client "suppressed-client"
+                            :transaction/bank-account "suppressed-bank"
+                            :transaction/date #inst "2022-06-01"
+                            :transaction/amount 100.0
+                            :transaction/approval-status :transaction-approval-status/approved)
+          (test-transaction :db/id "suppressed-tx"
+                            :transaction/client "suppressed-client"
+                            :transaction/bank-account "suppressed-bank"
+                            :transaction/date #inst "2022-06-02"
+                            :transaction/amount 250.0
+                            :transaction/approval-status :transaction-approval-status/suppressed)])]
+
+    (testing "Should leave a suppressed transaction out of the transactions page"
+      (let [{:keys [ids all-ids count]} (fetch suppressed-client)]
+        (is (= [kept-tx] (vec ids)))
+        (is (not (contains? (set all-ids) suppressed-tx))
+            "a suppressed transaction must not reach the amount total either")
+        (is (= 1 count)
+            "the row count has to match what the page renders, not the unfiltered scan")))
+
+    (testing "Should still list a transaction on an explicit status route"
+      (let [{:keys [ids]} (fetch suppressed-client
+                                 :route-params {:status :transaction-approval-status/approved})]
+        (is (= [kept-tx] (vec ids)))))
+
+    (testing "Should return nothing for a client whose transactions are all suppressed"
+      (let [{:strs [empty-client]}
+            (setup-test-data
+             [(test-bank-account :db/id "empty-bank")
+              (test-client :db/id "empty-client"
+                           :client/bank-accounts ["empty-bank"])
+              (test-transaction :db/id "only-tx"
+                                :transaction/client "empty-client"
+                                :transaction/bank-account "empty-bank"
+                                :transaction/date #inst "2022-06-03"
+                                :transaction/approval-status :transaction-approval-status/suppressed)])
+            {:keys [ids count]} (fetch empty-client)]
+        (is (empty? ids))
+        (is (= 0 count))))))