critique of wizard design.

test/clj/auto_ap/ssr/transaction/bulk_code_trial_test.clj

@@ -0,0 +1,104 @@
+(ns auto-ap.ssr.transaction.bulk-code-trial-test
+  (:require
+   [auto-ap.ssr.components.wizard-trial.state :as ws]
+   [auto-ap.ssr.transaction.bulk-code-trial :as sut]
+   [clojure.test :refer [deftest is testing use-fixtures]]
+   [mount.core :as mount]))
+
+(use-fixtures :each
+  (fn [test-fn]
+    (mount/start #'auto-ap.datomic/conn)
+    (test-fn)
+    (mount/stop #'auto-ap.datomic/conn)))
+
+(deftest open-trial-test
+  (testing "open-trial returns modal-response with a form containing expected fields"
+    (let [response (sut/open-trial {})]
+      (is (= 200 (:status response)))
+      (is (= "text/html" (get-in response [:headers "Content-Type"])))
+      (let [body (:body response)]
+        (is (string? body))
+        (is (re-find #"modal-card" body) "Should contain modal card structure")
+        (is (re-find #"Bulk editing" body) "Should show header with transaction count")
+        (is (re-find #"Vendor" body) "Form should contain Vendor label")
+        (is (re-find #"Status" body) "Form should contain Status label")
+        (is (re-find #"Expense Accounts" body) "Form should contain Expense Accounts heading")
+        (is (re-find #"Account" body) "Form should contain Account column header")
+        (is (re-find #"Location" body) "Form should contain Location column header")
+        (is (re-find #"%" body) "Form should contain percentage column header")
+        (is (re-find #"Save" body) "Form should contain Save button")
+        (is (re-find #"New account" body) "Form should contain New account button")
+        (is (re-find #"name=\"wizard-id\"" body) "Form should contain hidden wizard-id input")
+        (is (re-find #"name=\"step-key\"" body) "Form should contain hidden step-key input")))))
+
+(deftest submit-trial-valid-test
+  (testing "submit-trial with valid data returns success response and destroys session"
+    (let [wizard-id (ws/create! {})
+          request {:form-params {"wizard-id" wizard-id
+                                 "step-key" "bulk-code"
+                                 "vendor" "123"
+                                 "approval-status" "approved"
+                                 "accounts[0][account]" "1"
+                                 "accounts[0][location]" "DT"
+                                 "accounts[0][percentage]" "50"}}
+          response (sut/submit-trial request)]
+      (is (= 200 (:status response)))
+      (is (re-find #"Transactions Coded" (:body response)) "Response should indicate success")
+      (is (nil? (ws/get-wizard wizard-id)) "Wizard session should be destroyed after successful submit"))))
+
+(deftest submit-trial-invalid-test
+  (testing "submit-trial with invalid vendor id shows validation error"
+    (let [wizard-id (ws/create! {})
+          request {:form-params {"wizard-id" wizard-id
+                                 "step-key" "bulk-code"
+                                 "vendor" "not-a-number"
+                                 "approval-status" "approved"}}
+          response (sut/submit-trial request)]
+      (is (= 200 (:status response)))
+      (is (re-find #"error" (:body response)) "Response should contain error markup for invalid vendor")
+      (is (some? (ws/get-wizard wizard-id)) "Wizard session should persist after failed validation")))
+
+  (testing "submit-trial with invalid account data shows validation error"
+    (let [wizard-id (ws/create! {})
+          request {:form-params {"wizard-id" wizard-id
+                                 "step-key" "bulk-code"
+                                 "accounts[0][account]" "not-a-number"
+                                 "accounts[0][location]" "DT"
+                                 "accounts[0][percentage]" "50"}}
+          response (sut/submit-trial request)]
+      (is (= 200 (:status response)))
+      (is (re-find #"error" (:body response)) "Response should contain error markup for invalid account")
+      (is (some? (ws/get-wizard wizard-id)) "Wizard session should persist after failed validation")))
+
+  (testing "submit-trial with percentage over 100% shows validation error"
+    (let [wizard-id (ws/create! {})
+          request {:form-params {"wizard-id" wizard-id
+                                 "step-key" "bulk-code"
+                                 "accounts[0][account]" "1"
+                                 "accounts[0][location]" "DT"
+                                 "accounts[0][percentage]" "150"}}
+          response (sut/submit-trial request)]
+      (is (= 200 (:status response)))
+      (is (re-find #"error" (:body response)) "Response should contain error markup for percentage > 100%")
+      (is (some? (ws/get-wizard wizard-id)) "Wizard session should persist after failed validation"))))
+
+(deftest submit-trial-empty-test
+  (testing "submit-trial with empty form data shows validation errors"
+    (let [wizard-id (ws/create! {})
+          request {:form-params {"wizard-id" wizard-id
+                                 "step-key" "bulk-code"}}
+          response (sut/submit-trial request)]
+      (is (= 200 (:status response)))
+      (is (not (re-find #"Bulk code applied" (:body response))) "Empty form should not succeed")
+      (is (some? (ws/get-wizard wizard-id)) "Wizard session should persist after failed validation")))
+
+  (testing "submit-trial with no account rows selected shows validation errors"
+    (let [wizard-id (ws/create! {})
+          request {:form-params {"wizard-id" wizard-id
+                                 "step-key" "bulk-code"
+                                 "vendor" ""
+                                 "approval-status" ""}}
+          response (sut/submit-trial request)]
+      (is (= 200 (:status response)))
+      (is (not (re-find #"Bulk code applied" (:body response))) "Form with empty values should not succeed")
+      (is (some? (ws/get-wizard wizard-id)) "Wizard session should persist after failed validation"))))